Repository navigation
Track and triage CodeQL dependency vulnerabilities - #124
Merged
Merged
Conversation
Dependabot: - Force fast-xml-parser to >=5.7.0 via override in cleanup-storage, closing GHSA-jmr7-xgp7-cmfj (critical) plus 5 related advisories. - Bump js-yaml, lodash, minimatch, picomatch, flatted, brace-expansion and @humanfs/node transitive deps in cleanup-storage to their patched versions via nested overrides (scoped per parent so old and new major lines each get their own in-major patch, not a forced cross-major bump). uuid's vulnerable copy was eliminated entirely by a fresh resolve pulling in @azure/msal-node 5.6.0, which no longer depends on it. CodeQL: - js/insufficient-password-hash: rewrote verifyAIPassword to drop SHA-256 hashing entirely, comparing a length-prefixed, zero-padded fixed-size buffer with timingSafeEqual instead. This also fixes a latent correctness bug in the old hash-free padding approach we considered (a value zero-padded to the same length as the secret could otherwise collide). - js/missing-rate-limiting: replaced the hand-rolled in-memory bucket limiter for POST /ai/password/validate with the same express-rate-limit-backed factory already used for the other rate limited routes. - docker:S6505 / githubactions:S6505 (script execution during install): cleanup-storage/Dockerfile now uses `npm ci --ignore-scripts` (no native or lifecycle-script deps there). code/Dockerfile, code-verify.yml and code/package.json's "verify" script now use `npm ci --ignore-scripts` followed by an explicit `npm rebuild canvas sharp` plus the project's own copy:assets / apply:patches steps, replacing what its postinstall hook used to do, while blocking arbitrary lifecycle scripts from any other dependency. - docker:S8543 (lockfile not enforced): cleanup-storage/Dockerfile switched from `npm install` to `npm ci`. Not yet addressed: image-size (no upstream fix available for the two open DoS advisories) and @ai-sdk/provider-utils (low severity, no patched version in its 3.0.x line yet) - tracked as accepted risk for now.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #123