Skip to content

Resolve open Dependabot vulnerability alerts #139

Closed

Description

@alexmontesg

Context

There are open Dependabot alerts (https://github.com/InditexTech/weavejs-backend/security/dependabot) affecting ip-address, undici and brace-expansion, up to high severity.

Analysis

  • code/: the vulnerable copies live only inside the bundled node_modules of the npm package, which is declared as a dependency in code/package.json. The application's own copies are already patched. Nothing in the source, scripts, CI or Dockerfile uses the npm package; it appears to have been added by accident together with the unrelated install package. Removing it should close these alerts.
  • cleanup-storage/: brace-expansion 1.1.18 and 2.1.4 are pulled in through the dev-only eslint/prettier/glob chain. A lockfile update should fix them, with no runtime exposure.

Tasks

  • Remove the unused npm dependency (and the likely accidental install dependency) from code/package.json
  • Update brace-expansion (and minimatch/glob if needed) in cleanup-storage/
  • Run lint and build in both folders (npm run verify in code/)
  • Confirm the alerts are closed after merge
  • Consider grouped Dependabot updates for both npm folders to avoid recurrence

Activity

  1. alexmontesg commented on Oct 5, 2026

    @alexmontesg
    ContributorAuthor

    Note: after the changes in #140, npm audit will still report findings in code/ (12) and cleanup-storage/ (7). They all trace to a single advisory, GHSA-vfj7-8cjw-p6xm: stack-exhaustion DoS in braces (<=3.0.3).

    • No patched version exists (3.0.3 is the latest release), which is why Dependabot raises no alert for it.
    • The other packages in the audit (micromatch, fast-glob, globby, chokidar, patch-package, tsc-alias, nodemon, mastra, prettier-eslint, ...) are only transitive carriers. The npm audit fix suggestions are downgrades and should not be applied.
    • Exposure is limited to dev/build tooling that expands glob patterns, not the running service.

    Decision: leave as is for now and re-check once braces publishes a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions