Skip to content

feat(lesson): NPC dispatch speaker dislocation (#1655) - #1814

Merged
Ikalus1988 merged 2 commits into
Ikalus1988:mainfrom
zsxh1990:lesson/npc-dispatch-dislocation
Sep 19, 2026
Merged

Ikalus1988 merged 2 commits into
Ikalus1988:mainfrom
zsxh1990:lesson/npc-dispatch-dislocation

Conversation

@zsxh1990

Copy link
Copy Markdown
Contributor

Closes #1655. Intake from #1643.

NPC dispatched to external location + indirect mention of absent third party → spatial bilocation and active_speaker loss.

  • Problem: speaker resolution falls back to protagonist; spatial consistency not enforced per scene
  • Root Cause: pronoun resolution fallback chain + no scene-level location lock
  • Solution: P.O.V. generalization for NPCs, explicit active_speaker preservation, spatial consistency rule
  • Cross-refs: roleplay-vocative-entity-disambiguation, dialogue-loop-context-poisoning

Signed-off-by: Ikalus1988 Ikalus1988@users.noreply.github.com

…er loss

Closes Ikalus1988#1655. Intake from Ikalus1988#1643.

Signed-off-by: Ikalus1988 <Ikalus1988@users.noreply.github.com>
Signed-off-by: zsxh1990 <445655361@qq.com>
@Ikalus1988 Ikalus1988 added area:docs area:lessons lessons-only needs-human-review Content needs maintainer judgment (real experience, root cause quality) shape-safe labels Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

- domain: roleplay → roleplay-engine (canonical vocabulary)
- Added summary_plain, trigger, verify structured fields

Signed-off-by: Ikalus1988 <Ikalus1988@users.noreply.github.com>
Signed-off-by: zsxh1990 <445655361@qq.com>
@Ikalus1988
Ikalus1988 merged commit b727653 into Ikalus1988:main Sep 19, 2026
26 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

✅ Merged! Thanks again, @zsxh1990.

feat(lesson): NPC dispatch speaker dislocation (#1655) (+139 lines, 1 files)

Quick question — did any MisakaNet lesson help you this time?
→ Share feedback

No need to reply if nothing comes to mind. ⚡

@github-actions

Copy link
Copy Markdown
Contributor

🎉 Merged — Thank you!

Your contribution has been merged into main.

PR: #1814 — feat(lesson): NPC dispatch speaker dislocation (#1655)

What's next:

  • Your code is now part of MisakaNet's failure-lesson corpus (now 393 lessons)
  • Feel free to pick up another issue labeled good first issue or status: competition
  • Questions? Ask in this thread or open a Discussion

Welcome to the MisakaNet contributor community! 🧠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:docs area:lessons lessons-only needs-human-review Content needs maintainer judgment (real experience, root cause quality) shape-safe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bounty][$0][Lessons] 把 intake #1643(NPC 外派 + 间接提及 → 说话人/地点错位)转成课程

2 participants