Repository navigation
Apply TDP settings after Decky restarts (#216, rebased) - #223
Merged
Merged
Conversation
After a boot or a Decky restart, the plugin applied nothing until a game started, the TDP setting changed or the power source changed. The unload reverts the limits and starts thermald, so the firmware's limits applied: on a Claw 8 EX with an 8 W setting, PL1 30 W and PL2 37 W instead of 8 W and 10 W. The plugin now applies the TDP setting for the current power source at the end of its start. A power source with no setting keeps the firmware's limits and thermald, as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#216 by @anaveto, rebased onto main after #218 merged: both added a note at the top of STATUS.md's "Needs the maintainer". The commit is unchanged (author kept); the only resolution is keeping both notes.
main.py: at the end of_main, under the power lock, the TDP setting for the current power source is applied (_apply_idle_pick), so a Decky restart no longer leaves the firmware's limits with thermald running.test_tdp_setting_is_applied_when_the_plugin_starts.pytest: 320 passed, 1 skipped locally on main + this commit.Needs the Claw (listed in STATUS.md): set 8 W, restart plugin_loader, PL1 reads 8 W and thermald is inactive.
Generated by Claude Code