Conversation
…e single channel cases
…ort errors, add detailed error messages for RDS reading and writing, and validate Share UID in process_seurat function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving error handling, user feedback, and code robustness across several modules related to dataset upload, processing, and visualization. The most significant changes include replacing abrupt process exits with exceptions, providing more informative error messages, and improving logging for debugging and user communication.
Error handling and robustness improvements:
sys.exit()calls with appropriate exceptions (e.g.,ImportError,ValueError) inlib/gear/seuratuploader.pyto allow for better error propagation and handling in upstream code. [1] [2]process_seuratinwww/cgi/process_uploaded_expression_dataset.cgito handle missing share UIDs and conversion errors gracefully, writing status updates and error messages for the user interface. [1] [2]User feedback and logging:
www/js/upload_dataset.js.www/api/resources/spatialpanel.py, including writing tracebacks to a log file and cleaning up error logs on success.API and argument parsing improvements:
www/api/resources/tsne_data.pyto specify thelocation="json"for boolean and dictionary arguments, ensuring correct extraction of parameters from JSON requests.Minor code and documentation updates:
generate_spatial_image_dffunction and its docstring fromspatialpanel.pyfor code clarity.store_expression_dataset.cgi.datetime,traceback) for improved error handling.These changes collectively improve the reliability, maintainability, and user experience of the dataset upload and processing pipeline.