Conversation
What: replaces all instances of reticulum.io with reticulum.io-outdated. Why: reticulum.io was used extensively by Mozilla, but now that they are no longer doing things with Hubs (and since the Hubs Foundation doesn't own the domain), it's possible that these URLs could become a latent security risk.
Exairnous
added
the
Roadmap: Programming
|
@Exairnous Question: Is the point here to add the "-outdated" so that the link just does not work? |
Member
Author
Yes, exactly. (Though now it looks like we're going with |
Why: addresses review feedback from Hubs-Foundation/Spoke#1316 (comment) (.invalid is reserved for this purpose, so it's better to use that than our own fabrication of .io-outdated).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaces all instances of reticulum.io with reticulum.io.invalid.
reticulum.io-outdated.Why?
Reticulum.io was used extensively by Mozilla, but now that they are no longer doing things with Hubs (and since the Hubs Foundation doesn't own the domain), it's possible that these URLs could become a latent security risk.
Examples
N/A
How to test
reticulum.io(e.g.grep -r --exclude-dir={.git,node_modules} "reticulum.io").reticulum.iohave been replaced withreticulum.io.invalid.reticulum.io-outdated.Documentation of functionality
No functionality has changed, so no documentation update is needed.
Limitations
None.
Alternative implementations considered
Commenting out the references was considered, but invalidating them was deemed safer/easier.
Open questions
None.
Additional details or related context
The replacements were preformed with the following commands:
first
git grep -lz "reticulum.io" | xargs -0 sed -i '' -e 's/reticulum\.io/reticulum\.io-outdated/g'then (to address Hubs-Foundation/Spoke#1316 (comment))
git grep -lz "reticulum.io-outdated" | xargs -0 sed -i '' -e 's/reticulum\.io-outdated/reticulum\.io\.invalid/g'Part of roadmap item "Invalidate old Mozilla server links in repos with previously finished branding removal"