CI: storybook given write contents perms; RetPageOrigin removes all - #6584
Merged
Merged
Conversation
… all permissions Why: scopes the permissions to what is actually needed, for security
|
Thank you for the pull request. ROADMAP STATUS: This pull request isn't currently on any roadmap. Updates will be conveyed here as its place on/off a roadmap changes. You can view the roadmaps here: Roadmaps Google Drive folder. For more information on how the roadmaps work, see our roadmaps policy on GitHub. |
Exairnous
approved these changes
Jun 2, 2026
Exairnous
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks.
Note: This PR also removes branches from the list of triggers, I assume because no branches are specified which means it triggers on a push to any branch and thus the line doesn't do anything/isn't needed.
62 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
CI: storybook given write contents perms; RetPageOrigin removes all
Why?
scopes the permissions to what is actually needed, for security
Examples
n/a
How to test
Documentation of functionality
n/a
Limitations
none
Alternative implementations considered
For tighter security, we might rewrite the storybook workflow so we only need to give it write permission when it's on the master branch, but that would excessivly complicate a workflow we're not really taking advantage of.
Open questions
None
Additional details or related context
This probably should have been done as part of the earlier CI permissions PR.