Skip to content

CI: storybook given write contents perms; RetPageOrigin removes all - #6584

Merged
Exairnous merged 1 commit into
Hubs-Foundation:masterfrom
DougReeder:ci-fix-permissions
Jun 2, 2026
Merged

Exairnous merged 1 commit into
Hubs-Foundation:masterfrom
DougReeder:ci-fix-permissions

Conversation

@DougReeder

Copy link
Copy Markdown
Member

What?

CI: storybook given write contents perms; RetPageOrigin removes all

Why?

scopes the permissions to what is actually needed, for security

Examples

n/a

How to test

  1. cherry-pick the commit to the master branch of your personal repo
  2. push to GitHub; observe that both actions run without errors

Documentation of functionality

n/a

Limitations

none

Alternative implementations considered

For tighter security, we might rewrite the storybook workflow so we only need to give it write permission when it's on the master branch, but that would excessivly complicate a workflow we're not really taking advantage of.

Open questions

None

Additional details or related context

This probably should have been done as part of the earlier CI permissions PR.

… all permissions

Why: scopes the permissions to what is actually needed, for security
@github-actions

Copy link
Copy Markdown

Thank you for the pull request.

ROADMAP STATUS: This pull request isn't currently on any roadmap. Updates will be conveyed here as its place on/off a roadmap changes.

You can view the roadmaps here: Roadmaps Google Drive folder.

For more information on how the roadmaps work, see our roadmaps policy on GitHub.

@Exairnous Exairnous left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: This PR also removes branches from the list of triggers, I assume because no branches are specified which means it triggers on a push to any branch and thus the line doesn't do anything/isn't needed.

@Exairnous
Exairnous merged commit b3f6c0a into Hubs-Foundation:master Jun 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants