Avoid clearing fresh normalization bitmap - #59
Open
zachmdsi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid clearing the normalization visited bitmap immediately after allocating it.
uset_init()obtains freshMAP_ANONYMOUSstorage, which is already zero-filled. The subsequentuset_clear()touched the entire 512 MiB bitmap before every normal evaluation without changing its contents. This removes that call and the now-unused helper, while documenting the initialization invariant.Measurements
Measured on an Apple M5 with Apple Clang 21 (
clang -O2):lambda_evalmedian evaluation time: 1.528 s -> 1.481 scnot_24median evaluation time: 1.207 s -> 1.201 sThe primary benefit is avoiding a fixed 512 MiB resident-memory cost; timing gains are workload-dependent.
Validation
./devs/test/_all_.sh: 217 passed-O0,-O2,-O3, and-Os