fix(about): show ESP32-P4 on P4 firmware build#50
Conversation
|
Hi @Jestriker , Thank you so much for your contribution! Regarding being added as a contributor: if you are referring to your profile appearing in the 'Contributors' section on the repository’s main page, GitHub adds you there automatically as soon as I merge your Pull Request! However, I cannot manually add you to the project’s Team/Collaborators list with write access. This is because contributors with those permissions can push directly to branches without any PR or review, which is potentially dangerous for the project's security and stability. To maintain a proper code review process, I require all changes to go through Pull Requests. This ensures the integrity of the code while still giving you full credit for your work once the PR is merged. I hope you understand, and I look forward to more of your contributions! Best regards, Bin. |
|
Hi Bin, Best, |
|
okay, don't worry about your name in the contributors list. Once we merge the dev branch into main, you'll show up there automatically.😁 |
Summary
The About screen in
firmware_p4hard-codesHW: ESP32-S3, which is wrong — this is the ESP32-P4 firmware tree. Every user who opens About → Settings on a P4 build currently sees the wrong chip. One-line fix.Location
firmware_p4/components/Applications/ui/screens/about_settings/about_settings_ui.c:76Test plan
HW: ESP32-P4.Follow-ups (not in this PR)
The same screen also hard-codes
Version: DEVandBuild: Jan 2026. Happy to wire those to real values in a follow-up PR if maintainers want it.Hey maintainers — thanks for looking! I'd love to keep contributing to TentacleOS. If you're open to it, could I be added as a contributor? I have more PRs ready to go. Reach me on Discord: @justme.png