fix(config): read root config synchronously and bound rename retries by wall clock - #2191

Open

kriszyp wants to merge 47 commits into

mainfrom

kris/win-rename-retry-budget

Commits on Aug 28, 2026

fix(config): extend Windows atomic-write retry budget

kriszyp
and
codex
committed
4546f80
fix(config): bound Windows rename retries by time

kriszyp
and
codex
committed
9b7ebd9
fix(config): preserve short cross-platform rename retries

kriszyp
and
codex
committed
2b97099
fix(config): retry busy Windows renames

kriszyp
and
codex
committed
7011a5c
test(config): assert rename retry deadline

kriszyp
and
codex
committed
dbe3fe2
fix(config): close watched config reads synchronously

kriszyp
and
codex
committed
756bf1d
fix(config): close all root watcher reads synchronously

kriszyp
and
codex
committed
48a14f1
fix(config): harden rename retry options

kriszyp
and
codex
committed
fb737f3
fix(config): retry transient root config reads

kriszyp
and
codex
committed
f8aa359
test(config): arm root watcher listeners before writes

kriszyp
and
codex
committed
84e78aa
fix(config): narrow the config-write fix to the watcher self-contention

kriszyp
and
claude
committed
056b307
fix(config): converge both config watchers on one bounded read-retry ladder

kriszyp
and
claude
committed
8e7f6d6
fix(config): stop the read budget compounding across retry-ladder rungs

kriszyp
and
claude
committed
efe41d1
fix(config): redact config parse failures and close the watcher read after close()

kriszyp
and
claude
committed
0fdac5b
fix(config): resolve the config-watcher logger lazily

kriszyp
and
claude
committed
b4e7bf7
fix(config): boot on defaults when the config cannot be read or parsed

kriszyp
and
claude
committed
b3a1dff
fix(config): let a parser fault through with its own message

kriszyp
and
claude
committed
db7b5b8
fix(config): deliver config the synchronous read would otherwise drop

kriszyp
and
claude
committed
acc0c89
fix(config): re-read at arming, and guard both OptionsWatcher read paths

kriszyp
and
claude
committed
69d897f
fix(config): settle `ready` for a config that parses to nothing

kriszyp
and
claude
committed
e82b831
fix(config): settle both config barriers on every terminal read outcome

kriszyp
and
claude
committed
c3ae2fc
fix(config): stop the defaults being a shared mutable object, and close the arming gate

kriszyp
and
claude
committed
c8d3227
fix(config): settle the boot barrier with no config, not an empty one

kriszyp
and
claude
committed
ec4dcb5
fix(config): act on a config that arrives after the scope started, and stop ENOENT taking the ladder

kriszyp
and
claude
committed
5a22950
fix(config): report a watcher error without assuming a listener, and stop a falsy scope restarting

kriszyp
and
claude
committed
36bfed0
fix(config): keep the arming re-read after a scan error

kriszyp
and
claude
committed
9fac653
fix(config): arm the root-config OptionsWatchers, not just the root watcher

kriszyp
and
claude
committed
982b31c
fix(config): treat an unparseable read as mid-write, and settle every terminal watcher outcome

kriszyp
and
claude
committed
4b37cf4
fix(config): keep OptionsWatcher's failure paths inside the contracts they settle

kriszyp
and
claude
committed
5ddd577
fix(config): hold the boot barrier's retry timer, and contain every emit

kriszyp
and
claude
committed
ec959da
fix(config): clean up the temp file when the atomic write itself fails

kriszyp
and
claude
committed
b840d29
fix(config): treat env config that cannot be composed as no env config

kriszyp
and
claude
committed
430f28c
fix(config): contain the chokidar close() rejection in RootConfigWatcher.close

kriszyp
and
claude
committed
cba70d8
fix(config): contain the change emit, and clear a spent ladder on ENOENT

kriszyp
and
claude
committed
855b968
fix(config): reconcile with the merged Windows rename fix (#2339)

kriszyp
and
claude
committed
13af84b
fix(config): stop the arming re-read reporting a deletion, and pin what the platform-derived constants are worth

kriszyp
and
claude
committed
20ede1f
docs(config): record what the arming re-read must not report

kriszyp
and
claude
committed
79b383b
fix(config): close the gaps the independent review found in the arming and scope paths

kriszyp
and
claude
committed
057f61c
docs(config): record that scope presence is not the truthiness of its value

kriszyp
and
claude
committed
24c8c87
fix(config): settle the barrier on close, and stop a bare component key crashing the log update

kriszyp
and
claude
committed
7f32d0f
docs(config): trim the comments the review read as narration

kriszyp
and
claude
committed
1550ec5
docs(config): record what an empty read past the ladder costs each side

kriszyp
and
claude
committed
27f9c1d
test(components): stop the recreate case racing chokidar's own teardown

kriszyp
and
claude
committed
c6c78ca
test(logging): cover the two config guards through a seam, not a stub

kriszyp
and
claude
committed
993327e
fix(config): guarantee the temp file's cleanup again, and make the arm grace reachable

kriszyp
and
claude
committed
d63b1b4
fix(config): preserve file scope presence after default fallback

kriszyp
and
codex
committed
4f91e98
fix(config): report malformed env config after ready

kriszyp
and
codex
committed
fc15ab2