Skip to content

fix(types): widen recordCommitLatency parameter so the build type-checks #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kriszyp wants to merge 1 commit into from
Closed

fix(types): widen recordCommitLatency parameter so the build type-checks #1890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion resources/DatabaseTransaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ export function setCommitLatencyRecorder(recorder: ((durationMs: number) => void
// commit nor surface as an unhandled rejection on this floating `.then`. The thenable guard protects
// against a future caller passing a non-Promise `commitResolution` (today it is always the rocksdb-js
// async `Transaction.commit()` result, which is guaranteed to be a Promise).
function recordCommitLatency(commitResolution: Promise<void>, submittedAt: number) {
// Parameter widened to Promise<unknown> because callers may resolve with RETRY_NOW_VALUE (a number)
// on coordinated retry, but we only record the timing and never read the resolved value.
function recordCommitLatency(commitResolution: Promise<unknown>, submittedAt: number) {
if (!recordCommitLatencyMs) return;
const record = () => {
try {
Expand Down
Loading