Automerge workflow actions only, gate the rest - #702
Open
kriszyp wants to merge 6 commits into
Open
Conversation
Automerge is scoped to the github-actions manager because PR CI runs the workflows. No PR-triggered job builds Dockerfile, Dockerfile-gpu or Dockerfile-openshift, so a repo-wide automerge would have landed base-image bumps — including the fully-pinned nvidia/cuda runtime — on a suite that never compiled the image. Majors, 0.x minors, and the load-bearing dependency list never automerge, in step with harper's policy. rocksdb-js is disabled outright; its own release workflow proposes it. The root manifest stays disabled (those follow core), but matchFileNames is exact-path, so nested manifests under integrationTests/ remain managed — the description now says root manifest rather than implying all npm dependencies. matchFiles was the removed spelling and worked only through Renovate's config-migration shim. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request updates the Renovate configuration (renovate.json) to increase the concurrent PR limit, refine automerge rules, and add specific package rules for various dependencies. Feedback on the changes points out that Renovate's matchPackageNames does not support negation using the ! prefix, and suggests using excludePackageNames instead to properly exclude specific packages.
Contributor
|
Reviewed; no blockers found. |
dawsontoth
approved these changes
Aug 18, 2026
dawsontoth
left a comment
Contributor
There was a problem hiding this comment.
2 was mostly from when we were just getting started, if we stay on top of things, I don't think we'll get very high into the 20 range. I read that as effectively unlimited.
cb1kenobi
reviewed
Aug 18, 2026
Co-Authored-By: GPT-5 Codex <noreply@openai.com>
Co-Authored-By: GPT-5 Codex <noreply@openai.com>
cb1kenobi
reviewed
Aug 18, 2026
Co-Authored-By: GPT-5 Codex <noreply@openai.com>
Co-Authored-By: GPT-5 Codex <noreply@openai.com>
cb1kenobi
reviewed
Aug 18, 2026
Co-Authored-By: GPT-5 Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate now enables auto-merge only for GitHub Action updates in the integration and lint workflows. Current repository rules still require human approval, and every allowlisted action is exercised by a required pull-request check; release, scheduled, reusable AI-review, container-image, runtime, major, and pre-1.0 updates stay human-gated.
The eligible action occurrences use their own Renovate group. This keeps a shared action such as
actions/checkoutfrom landing in one branch that also edits unexercised publish workflows. The root manifest remains disabled because it follows core; nested integration-test manifests remain managed.rocksdb-jsstays disabled because its release workflow owns those proposals.prConcurrentLimitremains 20 so human-gated PRs cannot starve the action group. This is effectively an upper bound rather than an expected queue depth.For the human reviewer
automerge: trueenables GitHub auto-merge, but the activeMain - Require Reviewersruleset still requires one human approval and last-push approval; Renovate is not a bypass actor..github/workflows/integration-tests.yamlandlint-code.yaml.unit-tests.yamlis excluded because its current action references are already exercised by the required lint and integration jobs; excluding the file prevents a future unit-only action from silently entering the automerge group.groupSlug: "pr-test-workflow-actions"overrides the earlierall-digestsgrouping for allowlisted occurrences. Release and scheduled workflow occurrences remain in the human-gated group.Verification
--dry-run=fullsucceeds, resolves the config without migration, and extracts repository dependencies.npm run lint:required, targeted Prettier formatting, andgit diff --checkpass.Review coverage
Original policy authored by Claude Opus 5; review fixes authored by GPT-5 Codex. Earlier rounds used Claude and Gemini. The final review-feedback fix was independently reviewed by Gemini and Cursor Composer under the no-Claude quota policy; both completed, while Claude and domain adjudication were intentionally pruned. Their findings were broader pre-existing policy concerns or contradicted the approved intent and repository facts; neither identified a defect specific to removing the redundant unit-workflow entry.
Co-Authored-By: GPT-5 Codex noreply@openai.com
Human-Review-Need: 4 @ 2503a33