feat: 修改主页下载稳定版功能为在应用内更新 by Mine-diamond · Pull Request #5957 · HMCL-dev/HMCL

Mine-diamond · 2026-04-14T15:01:23Z

之前主页中预览版提示下载稳定版是打开HMCL官网的下载地址，但是在HMCL内更新应该是更好的选择

bandicam.2026-04-14.22-53-16-847.mp4

Glavo · 2026-04-17T02:43:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d01199be97

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-17T02:45:44Z

+                    RemoteVersion target = UpdateChecker.getLatestVersion();
+                    if (target != null) {
+                        UpdateHandler.updateFrom(target);


Gate stable upgrade on a successful stable check

This callback upgrades from UpdateChecker.getLatestVersion() as soon as checkingUpdate becomes false, but it does not verify that the just-finished check actually fetched a stable result. Because requestCheckUpdate is skipped when another check is already running and latestVersion is left unchanged when a check fails, clicking this link during an in-flight check (or after a failed stable check) can still install a stale dev/nightly version instead of switching to stable.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-17T02:45:44Z


+    public void onSwitchToStableChannel() {
+        Controllers.confirm(i18n("update.switch_to_stable.confirm"), i18n("update.switch_to_stable.title"), () -> {
+            UpdateChecker.requestCheckUpdate(UpdateChannel.STABLE, config().acceptPreviewUpdateProperty().get());


Request non-preview build when switching to stable

The new “switch to stable” flow passes acceptPreviewUpdate into requestCheckUpdate, so users who enabled preview updates will query stable-preview rather than stable. That conflicts with the UI text promising installation of the latest stable version and can keep users on pre-release builds after choosing this action.

Useful? React with 👍 / 👎.

3gf8jv4dv · 2026-04-19T21:28:15Z

 update.changelog=Changelog
 update.channel.dev=Beta
-update.channel.dev.hint=You are currently using a Beta channel build of the launcher. While it may include some extra features, it is also sometimes less stable than the Stable channel builds.\n\
+update.channel.dev.hint=You are currently using a Beta channel build of the launcher. While it may include some extra features, it is also sometimes less stable than the Stable channel builds. <a href="hmcl://update/switch-channel/stable">switch to Stable channel</a>\n\


Suggested change

update.channel.dev.hint=You are currently using a Beta channel build of the launcher. While it may include some extra features, it is also sometimes less stable than the Stable channel builds. <a href="hmcl://update/switch-channel/stable">switch to Stable channel</a>\n\

update.channel.dev.hint=You are currently using a Beta channel build of the launcher. While it may include some extra features, it is also sometimes less stable than the Stable channel builds. <a href="hmcl://update/switch-channel/stable">Switch to Stable channel</a>\n\

3gf8jv4dv · 2026-04-19T21:28:21Z

 update.channel.dev.title=Beta Channel Notice
 update.channel.nightly=Nightly
-update.channel.nightly.hint=You are currently using a Nightly channel build of the launcher. While it may include some extra features, it is also always less stable than the other channel builds.\n\
+update.channel.nightly.hint=You are currently using a Nightly channel build of the launcher. While it may include some extra features, it is also always less stable than the other channel builds. <a href="hmcl://update/switch-channel/stable">switch to Stable channel</a>\n\


Suggested change

update.channel.nightly.hint=You are currently using a Nightly channel build of the launcher. While it may include some extra features, it is also always less stable than the other channel builds. <a href="hmcl://update/switch-channel/stable">switch to Stable channel</a>\n\

update.channel.nightly.hint=You are currently using a Nightly channel build of the launcher. While it may include some extra features, it is also always less stable than the other channel builds. <a href="hmcl://update/switch-channel/stable">Switch to Stable channel</a>\n\

3gf8jv4dv · 2026-04-19T21:28:53Z

 update.note.dev=Suitable for users who want to experience new features first.\nThe development version includes the latest features and bug fixes,\nbut may also have more issues due to insufficient testing.
 update.latest=This is the latest version
 update.no_browser=Cannot open in system browser. But we copied the link to your clipboard, and you can open it manually.
+update.switch_to_stable.confirm=Switch to stable channel?\nThis will download and install the latest stable version.


Suggested change

update.switch_to_stable.confirm=Switch to stable channel?\nThis will download and install the latest stable version.

update.switch_to_stable.confirm=Want to switch to the stable channel of HMCL?\nClick "Yes" to download and install the latest stable version of HMCL.

3gf8jv4dv · 2026-04-19T21:29:52Z

 update.note.dev=适合希望优先体验新功能的用户使用。\n包含最新功能和错误修复，但未经充分测试，可能会存在更多问题。
 update.latest=当前版本为最新版本
 update.no_browser=无法打开浏览器。网址已经复制到剪贴板，你可以手动粘贴网址打开页面。
+update.switch_to_stable.confirm=是否切换到稳定版？\n这将会下载并安装最新的稳定版本。


Suggested change

update.switch_to_stable.confirm=是否切换到稳定版？\n这将会下载并安装最新的稳定版本。

update.switch_to_stable.confirm=是否切换至稳定版？\n这将会下载并安装最新的 HMCL 稳定版本。

3gf8jv4dv · 2026-04-19T21:30:17Z

 update.note.dev=適合希望優先體驗新功能的使用者使用。\n開發版會包含最新功能和錯誤修復，但未經充分測試，可能會存在更多問題。
 update.latest=目前版本為最新版本
 update.no_browser=無法開啟瀏覽器。網址已經複製到剪貼簿了，你可以手動複製網址開啟頁面。
+update.switch_to_stable.confirm=是否切換到穩定版？\n這將會下載並安裝最新的穩定版本。


Suggested change

update.switch_to_stable.confirm=是否切換到穩定版？\n這將會下載並安裝最新的穩定版本。

update.switch_to_stable.confirm=希望切換至穩定管道嗎？\n這將會下載並安裝最新的 HMCL 穩定版本。

3gf8jv4dv · 2026-04-19T21:35:42Z

 update.latest=目前版本為最新版本
 update.no_browser=無法開啟瀏覽器。網址已經複製到剪貼簿了，你可以手動複製網址開啟頁面。
+update.switch_to_stable.confirm=是否切換到穩定版？\n這將會下載並安裝最新的穩定版本。
+update.switch_to_stable.title=切換至穩定版


Suggested change

update.switch_to_stable.title=切換至穩定版

update.switch_to_stable.title=切換至穩定管道

3gf8jv4dv · 2026-04-19T21:36:18Z

 update.channel.dev.title=開發版提示
 update.channel.nightly=預覽版
-update.channel.nightly.hint=你正在使用 HMCL 預覽版。預覽版更新較為頻繁，包含一些未在穩定版和開發版中包含的測試性功能，僅用於體驗新功能。預覽版功能未受充分驗證，使用起來可能不穩定！\n\
+update.channel.nightly.hint=你正在使用 HMCL 預覽版。預覽版更新較為頻繁，包含一些未在穩定版和開發版中包含的測試性功能，僅用於體驗新功能。預覽版功能未受充分驗證，使用起來可能不穩定！<a href="hmcl://update/switch-channel/stable">切換至穩定版</a>\n\


Suggested change

update.channel.nightly.hint=你正在使用 HMCL 預覽版。預覽版更新較為頻繁，包含一些未在穩定版和開發版中包含的測試性功能，僅用於體驗新功能。預覽版功能未受充分驗證，使用起來可能不穩定！<a href="hmcl://update/switch-channel/stable">切換至穩定版</a>\n\

update.channel.nightly.hint=你正在使用 HMCL 預覽版。預覽版更新較為頻繁，包含一些未在穩定版和開發版中包含的測試性功能，僅用於體驗新功能。預覽版功能未受充分驗證，使用起來可能不穩定！<a href="hmcl://update/switch-channel/stable">切換至穩定管道</a>\n\

3gf8jv4dv · 2026-04-19T21:36:23Z

 update.changelog=更新日誌
 update.channel.dev=開發版
-update.channel.dev.hint=你正在使用 HMCL 開發版。開發版包含一些未在穩定版中包含的測試性功能，僅用於體驗新功能。開發版功能未受充分驗證，使用起來可能不穩定！\n\
+update.channel.dev.hint=你正在使用 HMCL 開發版。開發版包含一些未在穩定版中包含的測試性功能，僅用於體驗新功能。開發版功能未受充分驗證，使用起來可能不穩定！<a href="hmcl://update/switch-channel/stable">切換至穩定版</a>\n\


Suggested change

update.channel.dev.hint=你正在使用 HMCL 開發版。開發版包含一些未在穩定版中包含的測試性功能，僅用於體驗新功能。開發版功能未受充分驗證，使用起來可能不穩定！<a href="hmcl://update/switch-channel/stable">切換至穩定版</a>\n\

update.channel.dev.hint=你正在使用 HMCL 開發版。開發版包含一些未在穩定版中包含的測試性功能，僅用於體驗新功能。開發版功能未受充分驗證，使用起來可能不穩定！<a href="hmcl://update/switch-channel/stable">切換至穩定管道</a>\n\

Mine-diamond added 4 commits April 14, 2026 22:57

feat: 添加功能

8aa165a

feat: 优化代码

cf211fa

feat: 优化代码

91e92d7

fix: 修复错误

d01199b

Mine-diamond marked this pull request as ready for review April 15, 2026 13:57

chatgpt-codex-connector Bot reviewed Apr 17, 2026

View reviewed changes

3gf8jv4dv suggested changes Apr 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 修改主页下载稳定版功能为在应用内更新#5957

feat: 修改主页下载稳定版功能为在应用内更新#5957
Mine-diamond wants to merge 4 commits intoHMCL-dev:mainfrom
Mine-diamond:switch-stable

Mine-diamond commented Apr 14, 2026

Uh oh!

Glavo commented Apr 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Uh oh!

3gf8jv4dv Apr 19, 2026

Uh oh!

3gf8jv4dv Apr 19, 2026

Uh oh!

3gf8jv4dv Apr 19, 2026

Uh oh!

3gf8jv4dv Apr 19, 2026

Uh oh!

3gf8jv4dv Apr 19, 2026

Uh oh!

3gf8jv4dv Apr 19, 2026

Uh oh!

3gf8jv4dv Apr 19, 2026

Uh oh!

3gf8jv4dv Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	update.channel.dev.hint=You are currently using a Beta channel build of the launcher. While it may include some extra features, it is also sometimes less stable than the Stable channel builds. <a href="hmcl://update/switch-channel/stable">switch to Stable channel</a>\n\
	update.channel.dev.hint=You are currently using a Beta channel build of the launcher. While it may include some extra features, it is also sometimes less stable than the Stable channel builds. <a href="hmcl://update/switch-channel/stable">Switch to Stable channel</a>\n\

	update.channel.nightly.hint=You are currently using a Nightly channel build of the launcher. While it may include some extra features, it is also always less stable than the other channel builds. <a href="hmcl://update/switch-channel/stable">switch to Stable channel</a>\n\
	update.channel.nightly.hint=You are currently using a Nightly channel build of the launcher. While it may include some extra features, it is also always less stable than the other channel builds. <a href="hmcl://update/switch-channel/stable">Switch to Stable channel</a>\n\

	update.switch_to_stable.confirm=Switch to stable channel?\nThis will download and install the latest stable version.
	update.switch_to_stable.confirm=Want to switch to the stable channel of HMCL?\nClick "Yes" to download and install the latest stable version of HMCL.

	update.switch_to_stable.confirm=是否切换到稳定版？\n这将会下载并安装最新的稳定版本。
	update.switch_to_stable.confirm=是否切换至稳定版？\n这将会下载并安装最新的 HMCL 稳定版本。

	update.switch_to_stable.confirm=是否切換到穩定版？\n這將會下載並安裝最新的穩定版本。
	update.switch_to_stable.confirm=希望切換至穩定管道嗎？\n這將會下載並安裝最新的 HMCL 穩定版本。

	update.switch_to_stable.title=切換至穩定版
	update.switch_to_stable.title=切換至穩定管道

	update.channel.nightly.hint=你正在使用 HMCL 預覽版。預覽版更新較為頻繁，包含一些未在穩定版和開發版中包含的測試性功能，僅用於體驗新功能。預覽版功能未受充分驗證，使用起來可能不穩定！<a href="hmcl://update/switch-channel/stable">切換至穩定版</a>\n\
	update.channel.nightly.hint=你正在使用 HMCL 預覽版。預覽版更新較為頻繁，包含一些未在穩定版和開發版中包含的測試性功能，僅用於體驗新功能。預覽版功能未受充分驗證，使用起來可能不穩定！<a href="hmcl://update/switch-channel/stable">切換至穩定管道</a>\n\

	update.channel.dev.hint=你正在使用 HMCL 開發版。開發版包含一些未在穩定版中包含的測試性功能，僅用於體驗新功能。開發版功能未受充分驗證，使用起來可能不穩定！<a href="hmcl://update/switch-channel/stable">切換至穩定版</a>\n\
	update.channel.dev.hint=你正在使用 HMCL 開發版。開發版包含一些未在穩定版中包含的測試性功能，僅用於體驗新功能。開發版功能未受充分驗證，使用起來可能不穩定！<a href="hmcl://update/switch-channel/stable">切換至穩定管道</a>\n\

Conversation

Mine-diamond commented Apr 14, 2026

Uh oh!

Glavo commented Apr 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants