fix: recover BLE re-identify fixes from #28 + pairing-request timing - #29
Merged
Conversation
With ECDH now gated on characteristic readiness (#28), the pairing request had the same race: PairingView sent it on the connect event, before service discovery — the write would target a nil characteristic and be dropped. The coordinator now sends it from the readiness callback where discovery is guaranteed complete.
This was referenced Jul 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovers the fixes from #28 (closed by the author, who noted they're no longer pursuing the project — thank you @Souitou-iop, this was excellent work). Their commit is cherry-picked with authorship preserved:
pmset displaysleepnow(which was sleeping the developer's display during test runs)On top, one follow-up commit: the pairing request now goes out from the same readiness callback — sending it on raw connect had the identical race ECDH had.
Notably, #28's verification included a real-iPhone check: Face ID appeared over BLE and the daemon returned success.
Verification