tests: add queue and begin-time check in ephemeral cluster#162
Conversation
abhidg
force-pushed
the
155-ephemeral-cluster-tests
branch
2 times, most recently
from
7962910 to
a14c6e5
Compare
abhidg
force-pushed
the
155-ephemeral-cluster-tests
branch
from
e3af680 to
b00ce73
Compare
abhidg
requested review from
andreww,
colinsauze,
sadielbartholomew and
tonymugen
andreww
left a comment
andreww
left a comment
There was a problem hiding this comment.
Looks good to me, my main comment is that I think we need to make sure it runs if the cats code gets updated. Assuming that's the intention.
Otherwise, just some questions (and note that I'm not a Docker expert, so probably worth getting somebody else to glance at this too).
abhidg
force-pushed
the
155-ephemeral-cluster-tests
branch
2 times, most recently
from
2d6841e to
5f1738a
Compare
abhidg
force-pushed
the
155-ephemeral-cluster-tests
branch
from
5f1738a to
ecd3fd3
Compare
|
I finally got round to looking at this and it all looks good to me. But I tried to run it on my system and the container images are private and I don't have docker configured to login to github, so I can't run it. Is there any reason these should be private? |
|
I have made the container repository public but still get a login error - will try pushing an update and see if the latest image becomes public. Checked today - container image is public now @colinsauze |
3 participants
Fixes: #155