Skip to content

fix: clean up Teradata connection parameters - #1820

Merged
nj1973 merged 1 commit into
GoogleCloudPlatform:developfrom
miachillgood:codex/issue-1016-teradata-params
Aug 27, 2026
Merged

fix: clean up Teradata connection parameters#1820
nj1973 merged 1 commit into
GoogleCloudPlatform:developfrom
miachillgood:codex/issue-1016-teradata-params

Conversation

@miachillgood

Copy link
Copy Markdown
Contributor

Summary

  • let the Teradata driver supply its own port and authentication defaults when those options are omitted
  • apply explicit connection options after json-params, so command-line values take precedence
  • document the precedence and driver parameter names, with regression tests for both behaviors

Validation

  • python -m pytest tests/unit/ibis_teradata/test_init.py (6 passed)
  • python -m black --check third_party/ibis/ibis_teradata/api.py third_party/ibis/ibis_teradata/__init__.py tests/unit/ibis_teradata/test_init.py
  • python -m flake8 tests/unit/ibis_teradata/test_init.py
  • git diff --check

Fixes #1016

@nj1973

nj1973 commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

@nj1973
nj1973 self-requested a review August 27, 2026 10:02

@nj1973 nj1973 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, thanks for contributing to DVT!

@nj1973
nj1973 merged commit ee92c7d into GoogleCloudPlatform:develop Aug 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Teradata Connection Parameters may need cleanup and/or better documentation.

2 participants