Repository navigation
Handle extension_types "all" like Chrome does - #111
Open
patrickkettner wants to merge 2 commits into
Open
patrickkettner wants to merge 2 commits into
patrickkettner wants to merge 2 commits into
Conversation
Chrome's feature files can set extension_types to the string "all" instead of a list. includes() on that runs as a substring test, so "all" was read as excluding every type, and runtime.lastError has been missing from the MV3+ bundle since. ExtensionType was also missing chromeos_system_extension.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 44.41% 45.03% +0.62%
==========================================
Files 21 21
Lines 4215 4232 +17
Branches 293 301 +8
==========================================
+ Hits 1872 1906 +34
+ Misses 2343 2326 -17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
render-tsd.js has a top-level await run(), so importing it runs the tool. Move the class so its filter() method is testable, and add a test for the extension_types "all" case that caused the original bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome's feature files can set
extension_typesto the string"all"insteadof a list.
includes()on that runs as a substring test, so"all"was read asexcluding every type, and
chrome.runtime.lastErrorhas been missing from theMV3+ bundle since. That is the
runtime.lastErrorpart of #19, which also asksfor a
sendMessageoverload andchromeonWindow, so it stays open._all.d.tsdoes not change, so the documentation bundle is unaffected.ExtensionTypewas also missingchromeos_system_extension.