Skip code-fix assemblies when configuring Roslyn analyzers - #761
Draft
ZhaoMCX wants to merge 1 commit into
Draft
Conversation
igor84
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.CodeFixes.dllwhen deciding whether to add Unity'sRoslynAnalyzerlabel.Why
NuGet analyzer packages can contain both compiler analyzers/source generators and IDE-only code-fix assemblies in the
analyzersdirectory. NuGetForUnity currently labels every compatible DLL in that directory as a Roslyn analyzer.For example,
MessagePackAnalyzer3.1.3 containsMessagePack.SourceGenerator.dllandMessagePack.Analyzers.CodeFixes.dll. Unity then attempts to load the code-fix assembly and reports unresolved references toMicrosoft.CodeAnalysis.WorkspacesandSystem.Composition.AttributedModel.Code-fix assemblies are IDE tooling and should not be passed to Unity's compiler as analyzers. They remain installed but are excluded from Editor/platform loading by the existing importer behavior.
Validation
.CodeFixes.dllsuffixes.MessagePackAnalyzer3.1.3 from scratch and confirmed:MessagePack.Analyzers.CodeFixes.dllremains installed without theRoslynAnalyzerlabel.MessagePack.SourceGenerator.dllretains theRoslynAnalyzerlabel.Upstream CI note
The PR's
pull_request_targetjobs currently stop before running any tests because the repository's custom checkout action does not opt in to checking out fork code under GitHub's current security policy. The failure is limited to the Checkout step and is unrelated to this patch.