fix: ensure parent profile bindings are collected during reference resolution#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an important bug in the reference collection logic and improves the robustness of reference resolution for parent profiles and nested dependencies. The main change is the introduction of a fixed-point algorithm to ensure that all relevant references, including those introduced via parent profile hierarchies, are fully resolved. This prevents missing resources and improves correctness, especially for complex, multi-level dependencies.
Reference resolution improvements:
resolve_references_to_fixpoint()method incapability_statement_expander.pythat alternates between nested reference extraction and parent profile collection until no new resources are found, with a maximum of 10 passes to guarantee termination. This ensures that references from newly discovered parent profiles are not missed.