Repository navigation
Send SDK errors to zerolog and let callers downgrade handled errors - #17
Merged
Merged
Conversation
stripe-go logs its own errors before returning them, so a missing coupon we already handle still showed up as an `ERROR`. In this commit, SDK errors now go through zerolog and callers can decide which errors get downgraded to warn. Also added the Stripe error to the coupon log line, so the SDK error becomes truly redundant. We already dropped SDK Debug/Info/Warn before, and that remains the case now but it's still possible to surface them by changing `stripe.DefaultLeveledLogger`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stripe-go logs its own errors before returning them, so a missing coupon we already handle still showed up as an
ERROR. In this commit, SDK errors now go through zerolog and callers can decide which errors get downgraded to warn. Also added the Stripe error to the coupon log line, so the SDK error becomes truly redundant.We already dropped SDK Debug/Info/Warn before, and that remains the case now but it's still possible to surface them by changing
stripe.DefaultLeveledLogger.