Repository navigation
Conversation
wilsonwatson
reviewed
Oct 5, 2026
legoguy1000
reviewed
Oct 5, 2026
wilsonwatson
reviewed
Oct 6, 2026
wilsonwatson
requested changes
Oct 9, 2026
| @@ -69,6 +87,19 @@ public CameraProcessor(CameraConstants cameraConstants, @Nullable TurretCameraAd | |||
| */ | |||
| public Result<VisionObservation, RejectionReason> process(PhotonPipelineResult result, | |||
Member
There was a problem hiding this comment.
Remove the two-parameter version. It only serves to confuse us later. Everywhere that currently needs it should know if the robot is real or not.
| @@ -105,16 +94,30 @@ public void resetInit() { | |||
| */ | |||
| public void addOdometryObservation(SwerveModulePosition[] wheelPositions, Rotation2d gyroYaw, | |||
Member
There was a problem hiding this comment.
Same as other. Don't keep the 3-var version. Just use the 4 var version everywhere, otherwise we'll forget and get weirdness in sim.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.