Repository navigation
fix: allow installs on Node 21 through 26 - #87
Merged
Merged
Conversation
The engines range stopped at Node 20, so npm warned and Yarn 1 refused to install the package on any current LTS line. The upper bound stays, at the newest major the tests ran on; raise it when a new LTS is tested. The test script disabled native fetch because source-map 0.7.3 (used by jest's v8 coverage) mistook Node for a browser when fetch exists. Node 24 removed that flag, so source-map moves to 0.7.6, which fixes the detection, and the flag goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adamjudd
approved these changes
Nov 4, 2026
|
🎉 This PR is included in version 1.19.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@foxy.io/sdkv1 declared"node": ">=10 <=20". On any current Node LTS (22, 24, 26), npm warns withEBADENGINE, and Yarn 1 refuses to install. This raises the upper bound to 26, the newest major the tests ran on. The bound stays, so consumers only see versions we have tested.engines.node:>=10 <=26.NODE_OPTIONS=--no-experimental-fetch jest. Node 24 removed that flag, sonpm teststopped before jest started. The flag was a workaround forsource-map0.7.3, used by jest's v8 coverage, which took Node for a browser once nativefetchexisted. The lockfile moves it to 0.7.6, which fixes the detection, and the flag is gone. It is a dev-only dependency..nvmrcand the release workflow move from Node 20 to 22. Node 20 reached end of life in April 2026.Proof
npm test:Test Suites: 24 passed, 24 total,Tests: 271 passed, 271 totalon Node 20.20.2, 22.23.4, 24.22.1 and 26.13.0. Coverage thresholds pass on all four.npm run prepack(cjs, esm, types and CDN builds) passes on Node 20, 22, 24 and 26.Check by hand
npm view @foxy.io/sdk enginesshows>=10 <=26.Risks
node >=10.18. Its first run on 22 is this merge.🤖 Generated with Claude Code