Repository navigation
build: fix cdn uploads - #49
Merged
Merged
Conversation
samifiaz
previously approved these changes
Jun 28, 2024
brettflorio
previously approved these changes
Jun 28, 2024
brettflorio
left a comment
brettflorio
left a comment
Contributor
There was a problem hiding this comment.
Approving per @samifiaz for testing.
# Conflicts: # .github/workflows/s3cdn.yml
… the CDN The CDN job read the version from `git describe` while running in parallel with semantic-release, before the new tag existed. Every release would have uploaded to the previous version's paths, the same problem the foxy-elements Release workflow had. The release job now outputs the tag semantic-release created. The CDN job waits for it, passes it to the s3cdn action as LATEST_TAG_NAME, and is skipped when no release happened. It also invalidates the CloudFront cache after the upload, like foxy-elements does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
brettflorio
approved these changes
Oct 8, 2026
|
🎉 This PR is included in version 1.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK has never been uploaded to the Foxy CDN.
sdk@1,sdk@latestand every exact-version path return 404.This is the same workflow as in Elements after the CI fix: Foxy/foxy-elements#273
Before merging: this repo needs a
CLOUDFRONT_DISTRIBUTION_IDsecret. Today it only exists as a repo secret on foxy-elements. Without it, the upload still works, but the invalidation step fails.