Repository navigation
Conversation
…er a pick In the summary-item layout, options used `?selected`. Browsers ignore the selected attribute once the user has picked an option, so a value set by code after a pick left the native select on the old option. Bind `.selected` through `live()` instead. FX-792 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Add Customer service, Developer, Designer and Accountant presets to the Access level select. They prefill the Custom matrix and are not saved. A preset is offered only when the granter can grant all of it. The select shows a preset's name while the scope matches it exactly. - Move the Revoke button below the permissions, on one row with Save: Revoke on the left, Save on the right. - Label the user_invitations scope "Users and permissions" in the form and the card. FX-792 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… choose - When Custom is the only Access level option, apply it without a pick and don't render the select. The scope control then shows the "choose access" error itself, since the select was what displayed it. - Hide matrix rows the granter can't grant at any level, unless the invitation already holds them. An odd last row spans both columns. FX-792 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picking Custom while the scope still matched a role kept showing the role's name. An explicit Custom pick now wins until another preset is picked. Reopening an invitation still shows a matching role. FX-792 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pheekus
marked this pull request as ready for review
November 4, 2026 21:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UX improvements to the permissions part of
foxy-user-invitation-form(admin layout).Changes
Role presets
The Access level select now offers four presets next to Full, Read-only and Custom:
transactions_write customers_write subscriptions_write gift_cards_write coupons_read carts_read downloadables_read shipping_settings_read stores_readstores_write templates_write customer_portal_settings_write webhooks_write integrations_write item_categories_write shipping_settings_write shipping_integrations_write taxes_write subscription_settings_write downloadables_read coupons_read gift_cards_read carts_read transactions_read customers_read subscriptions_read reporting_readtemplates_write customer_portal_settings_write stores_read item_categories_readtransactions_read subscriptions_read customers_read reporting_read taxes_read gift_cards_read coupons_read stores_readRestricted granters
Layout and labels
user_invitationsscope is labelled "Users and permissions" in the form and the card. The token is unchanged.Testing
npm run lint: 0 errorsnpx tsc --noEmit: passnpm test: 8016 passed, 0 failedRefs FX-792