Skip to content

fix: harden docker deployment and monitoring hub URL resolution - #61

Merged
Foxlider merged 4 commits into
developfrom
feature/fix-docker-image
Aug 13, 2026
Merged

fix: harden docker deployment and monitoring hub URL resolution#61
Foxlider merged 4 commits into
developfrom
feature/fix-docker-image

Conversation

@Foxlider

@Foxlider Foxlider commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Summary

This PR fixes Docker runtime issues and improves reliability when KAST is deployed behind reverse proxies or under a path base. It ensures required Blazor web assets are present in published images, cleans up container/network configuration and docs, makes SignalR hub URL construction path-safe for both monitoring components, persists Data Protection keys in production, updates package versions, and refreshes a test double to keep end-to-end tests stable.


Type of Change

  • feat — new feature
  • fix — bug fix
  • perf — performance improvement
  • refactor — code restructure, no behaviour change
  • docs — documentation only
  • chore / ci — build, tooling, dependencies
  • Breaking change — existing behaviour changes (add ! to the PR title type)

What Changed

  • Added publish-time guard in Dockerfile to fail image build if Blazor web assets are missing.
  • Added RequiresAspNetWebAssets in KAST.UI project to guarantee web assets are included.
  • Updated docker-compose networking and env setup:
  • removed incorrect TCP publication for Arma game range
  • documented UDP-only Arma game range usage
  • added Kast__InternalBaseUrl for server-side hub calls
  • Simplified and corrected nginx reverse-proxy config for Blazor/SignalR/API with proper upgrade and forwarded headers.
  • Rewrote README Docker and Arma port documentation for clearer setup, port purpose explanation, and BattlEye RCon guidance.
  • Expanded .dockerignore to reduce build context size/noise (git, IDE, artifacts, generated outputs, test results).
  • Updated central package versions (ASP.NET/EF/OpenTelemetry/MudBlazor/test tooling) and added explicit SQLitePCLRaw package set.
  • Updated hub URL construction in both NavMenu and MonitorTab to preserve path-base deployments and safely handle invalid/missing InternalBaseUrl.
  • Added production Data Protection key persistence to /app/data/keys so protected browser data survives container recreation.
  • Improved end-to-end test NoopAppEventBroadcaster event members with explicit add/remove accessors for safer test-double behavior.

Testing

  • Existing tests pass (dotnet test)
  • New tests added for the changed behaviour
  • Manually tested — describe below if relevant

Manual/verification notes:

  • dotnet test --no-build
  • Result: total 160, failed 0, succeeded 160, skipped 0
  • dotnet build KAST.UI.csproj --no-restore

Checklist

  • PR title follows Conventional Commits format
  • Targets the correct branch (develop for features, main for hotfixes)
  • No unrelated changes mixed in (whitespace, refactors, unrelated fixes)
  • EF Core migration included if any entity model changed
  • I have read CONTRIBUTING.md

@github-actions github-actions Bot added documentation Improvements or additions to documentation area: ci area: ui labels Aug 13, 2026
Comment thread src/KAST.UI/Program.cs Fixed
@Foxlider
Foxlider force-pushed the feature/fix-docker-image branch from 4d4c925 to e6a3969 Compare August 13, 2026 00:08
@Foxlider Foxlider self-assigned this Aug 13, 2026
@Foxlider
Foxlider merged commit fddf7ed into develop Aug 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci area: ui documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants