fix(mcp): stop empty UI-tool errors and tighten tool-usage guardrails#7911
Open
andypalmi wants to merge 14 commits into
Open
fix(mcp): stop empty UI-tool errors and tighten tool-usage guardrails#7911andypalmi wants to merge 14 commits into
andypalmi wants to merge 14 commits into
Conversation
added 5 commits
July 22, 2026 00:21
platform_list_stacks returned every stack across every instance type with no way to tell which one was current, so "use the latest" was ambiguous and a superseded Node-RED version could be selected. Scope the tool to a chosen instance type, using the same projectType filter as the real stacks endpoint, and surface that type's defaultStack as the recommended latest version, both in the tool description and in platform_create_hosted_instance's guidance.
The application-instances list carries no instance type, stack, or template, and no tool description said so, so a request to read or match an existing instance's specification had no reliable source and could be answered with a guess reported as fact. Note on the list tool that it omits the specification, and point both it and the create-instance guidance at platform_get_hosted_instance, which already returns the full specification.
router.resolve throws an Error with no message (only extra own
properties) for an unknown route name in a production build, which the
dispatcher's catch collapsed to `err.message` and lost entirely. The
dispatcher now falls back to the error's own properties when message is
empty. ui_navigate also now catches resolve/push directly and returns a
clean, structured failure instead of letting an unnamed-route lookup
throw past it, and ui_list_routes stops hiding named redirect-only
routes (like an application's landing route) from route discovery.
Closes FlowFuse/engineering#188
…isions
ui_navigate's id param now warns explicitly that it must be a real
entity id from a list/get tool, never a display name, and clarifies
that success: true only confirms the route matched - not that the
target entity exists.
platform_create_application now says to check platform_list_applications
for a name collision before creating one. platform_create_remote_instance
now says to assign the device to an application right away when the user
references one, instead of leaving it unassigned by default.
platform_create_hosted_instance makes the name-availability check
mandatory and says to offer the user alternative names on a collision
rather than picking one silently.
Closes FlowFuse/engineering#185, FlowFuse/engineering#182, FlowFuse/engineering#183
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7911 +/- ##
==========================================
- Coverage 75.72% 75.61% -0.11%
==========================================
Files 434 434
Lines 23198 23232 +34
Branches 6161 6172 +11
==========================================
+ Hits 17567 17568 +1
- Misses 5631 5664 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cstns
reviewed
Jul 24, 2026
Co-authored-by: Costin Serban <cstn.serban@gmail.com>
Co-authored-by: Costin Serban <cstn.serban@gmail.com>
Replace platform_list_hosted_instance_types and platform_list_stacks with a single tool that nests each instance type's stacks and flags available/creatable per team, defaulting to creatable-only results.
added 2 commits
July 24, 2026 12:59
…dling Move the error-describing fallback out of automations.service.ts into frontend/src/mcp/tools/errors.ts and reuse it in ui_navigate, so a NavigationFailure with no message surfaces its details instead of a generic fallback string.
Contributor
Author
|
@cstns I've already applied your suggestions in this PR. The only additional change is the commit I just pushed: extracted the describeError fallback out of automations.service.ts into a shared frontend/src/mcp/tools/errors.ts helper, and reused it in ui_navigate so a NavigationFailure with no message surfaces its details instead of a generic string. Could I get your review on this again, and if it looks good, an approve? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #7908.
Summary
ui_navigate(and any other UI automation tool) could returnTool "X" failed:with nothing after the colon, because vue-router throws anErrorwith nomessagein production for an unknown route name, and the dispatcher's catch collapsed straight toerr.message. The dispatcher now falls back to the error's own properties so the reason is never lost.ui_navigatealso now catchesresolve/pushdirectly and returns a clean, structured failure.ui_list_routesno longer hides named redirect-only routes (like an application's landing route) from discovery.platform_create_application/platform_create_remote_instance/platform_create_hosted_instanceare explicit about checking for name collisions before creating and asking the user instead of guessing.Closes
Test plan
npx vitest run --config ./config/vitest.config.ts test/unit/frontend/mcp/tools/navigation.spec.js test/unit/frontend/mcp/tools/routes.spec.js test/unit/frontend/services/automations.service.spec.js- all passingnpx eslinton all touched files - clean