feat(installer): Add possibility to provide custom CA bundle certificate#702
Conversation
allthedoll
left a comment
There was a problem hiding this comment.
This looks good to merge to me as is. The flag is off by default so ship risk is low, and reusing the stored cert on reinstall is ✨.
I think you should add a smol unit test for InstallCACertificate, though, which can be done in another iteration. Something for the empty/missing/not-a-file cases so a future change can't silently skip the CA.
I have two other points to consider:
--ca-certis ignored on--update-agentwhere it'd be nice to have a doc line or comment- On Linux/MacOS the file is read into memory and also copied via temp file, so IMHO the
os.ReadFilecould probably be dropped since the temp file is what gets copied?
This is really nice work though, @ppawlowski and I appreciate the code comments.
Added a comment to readme regarding when the
While that's true, I use this approach in a few other places too. The goal is to not pass an operator-provided path straight to |
Description
This pull request introduces the
--ca-certflag to the Device Agent Installer that allows to pass the Certificate Authority certificate bundle file to be trusted by the Device Agent.This change allows to quickly onboard the Remote Instance using the Installer in environments where self-signed certificates have been used to deploy the FlowFuse Platform.
Related Issue(s)
Closes #698
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel