[Plugin] Add ShowPilot-Lite#44
Conversation
Requested in #43.
|
I added the submit flag on the issue simply to show that I am not the owner, but that I have approval from the owner to submit. I have corrected the other findings, but the PR for those findings is still pending approval. Therefore, I didn't run the recheck in the issue and didn't realize that it would be closed out and this PR would be opened. I can update here when my PR for the showpilot lite repo is complete. I apologize for jumping the gun on the issue template. |
|
/recheck |
🔄 RecheckPlugin: ShowPilot-Lite Requested by @bjhiltbrand - 3 issue(s) currently outstanding:
This comment reflects the repo's current state; it does not change the PR itself - merging is still a maintainer's call. |
|
@bjhiltbrand No problem - this workflow is new and we are tuning the wording and checks based on learnings as we go. Given the github account that has submitted the request is different to the github account that owns the plugin, we would like you to add the proof to the json file to prove ownership. In addition to the automated checks, we have concerns with the plugin. Our understanding is that there is the potential for the plugin owner to reconfigure the Cloudflare tunnel remotely at any time without warning and gain live remote access to the fpp and hence the end-users full local network. Assuming that is the case, it is a risk that would need further discussion prior to plugin approval. |
|
/recheck |
🔄 RecheckPlugin: ShowPilot-Lite Requested by @darylc - 6 issue(s) currently outstanding:
This comment reflects the repo's current state; it does not change the PR itself - merging is still a maintainer's call. |
|
I'm the owner of the repo. The ShowPilot Lite version is only configurable
from the local FPP. There are no cloud ties to anything other than the end
users Cloudflare account.
…On Sat, Jul 25, 2026 at 7:57 PM darylc ***@***.***> wrote:
*darylc* left a comment (FalconChristmas/fpp-data#44)
<#44 (comment)>
@bjhiltbrand <https://github.com/bjhiltbrand> No problem - this workflow
is new and we are tuning the wording and checks based on learnings as we go.
Given the github account that has submitted the request is different to
the github account that owns the plugin, we would like you to add the proof
to the json file to prove ownership.
In addition to the automated checks, we have concerns with the plugin. Our
understanding is that there is the potential for the plugin owner to
reconfigure the Cloudflare tunnel remotely at any time without warning and
gain live remote access to the fpp and hence the end-users full local
network. Assuming that is the case, it is a risk that would need further
discussion prior to plugin approval.
—
Reply to this email directly, view it on GitHub
<#44?email_source=notifications&email_token=ATLA4GROETY36QLBEVSZNDT5GVJPLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBYGEZDSNJRGQ22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5081295145>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATLA4GRP4SO6IOBMVHV7LI35GVJPLAVCNFSNUABFKJSXA33TNF2G64TZHM2TAMZYGIZTKOJYHNEXG43VMU5TIOJXGYYTOMRWGIZKC5QC>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@bjhiltbrand Thanks for the clarification on the Cloudflare aspect, that makes more sense. This plugin is quite complex compared to the average FPP plugin, so it will take some time for the FPP developers to complete their review. |
Adds
ShowPilot-LitetopluginList.json, requested in #43.Plugin repo: https://github.com/ShowPilotFPP/ShowPilot-Lite
pluginInfo.json: https://raw.githubusercontent.com/ShowPilotFPP/ShowPilot-Lite/refs/heads/main/pluginInfo.json
Submitted by: @bjhiltbrand
Registered owner (from srcURL): @ShowPilotFPP - differs from the submitter and was not verified; note the contact email on file is the submitter's, not necessarily the owner's. (This PR still only opened because the reporter used
/submitto override that finding.)/submitto ask for review anyway rather than fix them first:ShowPilotFPP, this repo's registered owner (from srcURL). Add"submissionToken": "fpp-43"to your pluginInfo.json and comment/recheckto prove you have write access here - or, if you're submitting on the owner's behalf with their consent, comment/submitinstead to flag this for a maintainer's judgement rather than auto-verifying.curl -fsSL https://deb.nodesource.com/setup_22.x | sudo -E bash -) - install the dependency through a package manager FPP already has instead:apt-get installfor system packages,npm installfor Node packages, orpip install --break-system-packagesfor Python packages. Only if there's genuinely no package for it, download the installer to a file, verify its checksum, then run it, e.g.curl -fsSLo installer.sh https://example.com/install.sh && echo "<sha256> installer.sh" | sha256sum -c && bash installer.shcurl -fsSL https://deb.nodesource.com/setup_22.x | sudo -E bash -) - install/hooks already run as root, so remove the sudo call and run the command directly, e.g.curl -fsSL https://deb.nodesource.com/setup_22.x | -E bash -$settings['logDirectory']."/plugin-ShowPilot-Lite.log"(PHP) or the equivalent in your language, so the service's output surfaces in FPP's log viewer and Support Zip instead of only wherever stdout happens to gocurl -fsSL https://deb.nodesource.com/setup_22.x | sudo -E bash -) - a hung remote server stalls this indefinitely, blocking whatever hook/show command triggered it. SetCURLOPT_TIMEOUT/CURLOPT_CONNECTTIMEOUT(PHP curl), the'timeout'key (PHP stream contexts), ortimeout=(Pythonrequests)<script src="https://cdnjs.cloudflare.com/ajax/libs/Chart.js/4.4.1/chart.umd.min.js"></script>) - FPP's web shell already bundles Bootstrap/jQuery, and a show network is often offline/isolated, so a CDN dependency can silently fail to load. Use FPP's already-loaded copy instead of pulling your own from a CDNSchema, category, and archived/issues-disabled were already checked before this PR existed.
Merging is entirely up to a maintainer's judgement - this PR being open is not an approval, especially if it was opened via
/submitover unresolved findings above.A repo maintainer (or @bjhiltbrand) can comment
/recheckhere to re-run the plugin check against the repo's current state and refresh the findings above.