Fix/ja jp postcode leading zero#1041
Open
hunhunyosshy wants to merge 2 commits into
Open
Conversation
Changed postcode1() and postcode2() to use numerify() to preserve leading zeros, which are common in regions like Hokkaido.
tomoikey
approved these changes
Feb 20, 2026
tomoikey
approved these changes
Feb 20, 2026
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
Author
|
Could you review and merge it if no problem? |
Author
|
Could you review and merge it if no problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
In Japan, some regions (notably Hokkaido) have postal codes starting with zero (e.g.,
001-XXXX). The previous implementation usednumberBetween(), which resulted in integers. When these were concatenated, leading zeros were lost (e.g.,001became1). This PR ensures leading zeros are preserved by usingnumerify().Author's checklist
Summary of changes
postcode1()andpostcode2()inFaker\Provider\ja_JP\Addressto usenumerify('###')andnumerify('####')instead ofnumberBetween().@exampletags to reflect string return values.test/Faker/Provider/ja_JP/AddressTest.phpto ensure the postcode format is correctly generated.Review checklist
CHANGELOG.md