Skip to content

Start contributing.md - #6

Closed
cassiancc wants to merge 2 commits into
FabricMC:feature/conventionsfrom
cassiancc:contributing
Closed

cassiancc wants to merge 2 commits into
FabricMC:feature/conventionsfrom
cassiancc:contributing

Conversation

@cassiancc

@cassiancc cassiancc commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Adds basic information about how to contribute using mcsrc.dev. Structure and some wording are pulled from Parchment's contributing guidelines, which are licensed under CC0.

References #5, so this PR should either be merged after that one or as part of that one.

@modmuss50

Copy link
Copy Markdown
Member

FYI I made my branch on this repo, so you can PR my PR easily if you want.

@cassiancc
cassiancc changed the base branch from 26.3 to feature/conventions November 2, 2026 17:19
Comment thread .gitignore Resolved
Comment thread CONTRIBUTING.md
Comment on lines +17 to +19
1. **Fork the repository.** Forking the repository creates a copy of the repository (your _fork_) at your personal account, where you push your own commits to your branches.

1. **Clone your forked repository locally.** The repository directory can have any name, by default cloning will make a directory with the same name as the repository.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really necessary to explain what a fork and cloning is, especially since the document also requires you to have basic knowledge of git?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not, but it's a short reminder more than a detailed expalnation.

Comment thread CONTRIBUTING.md

1. **Clone your forked repository locally.** The repository directory can have any name, by default cloning will make a directory with the same name as the repository.

1. **Open mcsrc.dev and select the Settings gear icon in the top left, select Tools in the left sidebar, then click Open Annotater directory.** [mcsrc.dev](https://mcsrc.dev/) allows you to view the Minecraft source and add Javadocs. This will give the site permission to write to your local Annotater repository, making it far easier to contribute documentation

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. **Open mcsrc.dev and select the Settings gear icon in the top left, select Tools in the left sidebar, then click Open Annotater directory.** [mcsrc.dev](https://mcsrc.dev/) allows you to view the Minecraft source and add Javadocs. This will give the site permission to write to your local Annotater repository, making it far easier to contribute documentation
1. **Open [mcsrc.dev](https://mcsrc.dev/) and select the *Settings* gear icon in the top left. Then select *Tools* in the left sidebar, click on *Open Annotater directory* and select your local repository. Your browser will then ask for permission to write to your file system.** The website allows you to view the decompiled Minecraft source and add Javadocs to it.

Do you think it would be nice to have images in here as well so people can see what they have to do? On top of that, maybe you could split this section up into smaller steps instead of bunching all of opening Annotater in one big step, as it's a lot of small things to ask for?

Image

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, I think images would be handy. I was also considering checking with modmuss to see if mcsrc could be updated to allow linking directly to the Javadoc settings panel, I'll do that now.

@modmuss50
modmuss50 deleted the branch FabricMC:feature/conventions November 6, 2026 14:55
@modmuss50 modmuss50 closed this Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants