Allow use of tab in editor panel, fix tab skipping tokens#578
Merged
Conversation
Earthcomputer
approved these changes
Oct 19, 2025
Earthcomputer
left a comment
Earthcomputer
left a comment
Contributor
There was a problem hiding this comment.
It's a little bit over-documented now but that's fine. I personally would have said something simpler like "make sure to call this when the tokens are up-to-date" ("damaged" is a bit of a weird word to use here). And then where invokeLater is actually used, add a comment to say that the tokens aren't up-to-date but will be inside the invokeLater.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed running Enigma from an IDE such as eclipse (since it isn't a real bug per-se I don't think that it's worthy of its own PR and thus got shoved into this PR).
The tab skipping tokens aspect of this PR is caused when renaming very long references to short names. Previously it'd be searching for the next token in relation to the end of the obfuscated token, but now it does so in relation to the end of the renamed token.
All in all this is a less invasive fix than what I had initially planned (i.e. only handling tabbing logic in the ConvertingTextField), so there's no rewrite of components in this PR.