Skip to content

fix(parser): accept single-value rvalues and C-style block comments #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThVerg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(parser): accept single-value rvalues and C-style block comments #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sdf_toolkit/parser/sdf.lark
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ port_spec: STRING
// Real value (single or triple)
rvalue: FLOAT
| "(" [real_triple] ")"
| "(" FLOAT ")"

real_triple: [FLOAT] ":" [FLOAT] ":" [FLOAT]

Expand Down Expand Up @@ -181,3 +182,5 @@ STRING: /[a-zA-Z0-9_\/.\[\]\\$]+/
%ignore WS
COMMENT: /\/\/[^\n]*/
%ignore COMMENT
BLOCK_COMMENT: /\/\*[\s\S]*?\*\//
%ignore BLOCK_COMMENT
5 changes: 3 additions & 2 deletions src/sdf_toolkit/parser/transformers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,10 @@ def rvalue(self, *args: float | Values | Token | None) -> Values:
if isinstance(arg, Values):
return arg
if isinstance(arg, float):
return Values(min=None, avg=arg, max=None)
return Values(min=arg, avg=arg, max=arg)
if isinstance(arg, Token) and arg.type == "FLOAT":
return Values(min=None, avg=float(arg), max=None)
value = float(arg)
return Values(min=value, avg=value, max=value)
return Values()

@v_args(inline=True)
Expand Down