fatfs.c: fix to the fix to the fix, only write file size if appended#246
Merged
PerditionC merged 1 commit intoFDOS:masterfrom Apr 23, 2026
Merged
Conversation
The prior revision incorrectly corrupted the file size even if just scanning the file, including for read. Move the code so it only runs after the very spot that found it is writing, needed to append a new cluster to the chain, and successfully did do that. Script for lDebug file to test this error: === testtrun.sld e 200 "A:\test.dat" 0 f 400 l 400 38 a mov ah, 3C mov cx, 0 mov dx, 200 int 21 xchg bx, ax mov ax, 4200 mov cx, (#10240 >> 10) mov dx, (#10240 & FFFF) int 21 mov ah, 40 mov dx, 400 mov cx, 0 int 21 mov ah, 68 int 21 nop mov ax, 4200 xor cx, cx xor dx, dx int 21 mov dx, 800 mov ah, 3F mov cx, 380 int 21 int3 mov ah, 68 int 21 nop int3 nop jmp 100 . ===
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior revision incorrectly corrupted the file size even if just scanning the file, including for read. Move the code so it only runs after the very spot that found it is writing, needed to append a new cluster to the chain, and successfully did do that.
Script for lDebug file to test this error: