fix(security): validate WHIP/WHEP OPTIONS path params - #300
Open
birme wants to merge 1 commit into
Open
Conversation
…hema Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
birme
commented
Sep 10, 2026
birme
left a comment
Contributor
Author
There was a problem hiding this comment.
Code Review
Verdict: LGTM
Summary: Adds a TypeBox params schema (productionId/lineId, String, minLength 1, maxLength 200) to the WHIP and WHEP OPTIONS handlers, closing the AJV validation gap in #249. Minimal, correct, consistent with the maxLength-constraint convention used elsewhere in the codebase.
Blocking
None.
Warnings
None.
Suggestions
src/api_whip.ts/src/api_whep.ts— the two handlers now carry an identical params schema; a shared constant would avoid drift, but duplication of a 4-line schema is acceptable.
daily-backlog-pr Phase 3 review. CI: all checks passing. Note: not auto-merging this run — see run summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paramsschema to the WHIP OPTIONS handler (/whip/:productionId/:lineId) validatingproductionIdandlineId(String, minLength 1, maxLength 200).paramsschema to the WHEP OPTIONS handler (/whep/:productionId/:lineId).Test plan
npm run typecheckcleannpm testall pass (243 tests; "worker process has failed to exit gracefully" warning is expected)Closes #249