chore: bump Fastify, fix OSC_ENVIRONMENT override, remove stray dotenv.config() - #254
Open
LucasMaupin wants to merge 1 commit into
Open
chore: bump Fastify, fix OSC_ENVIRONMENT override, remove stray dotenv.config()#254LucasMaupin wants to merge 1 commit into
LucasMaupin wants to merge 1 commit into
Conversation
…tray dotenv.config() - Bump fastify ^5.7.3 → ^5.8.5 (patches GHSA-247c-9743-5963 body validation bypass) - docker-entrypoint.sh: preserve pre-set OSC_ENVIRONMENT instead of always overriding (#247) - Remove stray dotenv.config() call from api_productions.ts (#147) Closes #247, Closes #147, Closes #221
This was referenced Jun 24, 2026
Closed
Security: Update Fastify and dependencies to patch body validation bypass (GHSA-247c-9743-5963)
#221
Open
birme
reviewed
Sep 10, 2026
birme
left a comment
birme
left a comment
Contributor
There was a problem hiding this comment.
Code Review
Verdict: LGTM
Summary: Bumps fastify ^5.7.3 → ^5.8.5 (patches GHSA-247c-9743-5963, body-validation bypass), guards OSC_ENVIRONMENT in docker-entrypoint.sh so a pre-set value isn't clobbered, and removes a stray dotenv.config() from api_productions.ts. package.json and package-lock.json are consistent.
Blocking
None.
Warnings
None.
Suggestions
src/api_productions.ts— removingdotenv.config()here is safe becausesrc/config/load-env.tshandles env loading and is imported transitively (viasrc/db/mongodb.ts); confirmed present and CI green. Notesrc/api_ingests.tsstill callsdotenv.config()— that's the separate regression tracked in #274, correctly out of scope here.- PR closes #147/#221/#247 together; fine given each change is small, but multi-issue PRs are harder to revert individually.
daily-backlog-pr Phase 3 review. CI: all checks passing. Note: not auto-merging this run — see run summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fastifyfrom^5.7.3to^5.8.5to patch GHSA-247c-9743-5963 (body validation bypass)docker-entrypoint.sh: respect a pre-setOSC_ENVIRONMENTvalue instead of always overriding it (closes docker-entrypoint.sh: allow OSC_ENVIRONMENT override #247)dotenv.config()call fromsrc/api_productions.ts— config loading is already handled insrc/config/load-env.ts(closes Removedotenv#147)Closes #147, Closes #221, Closes #247
Test plan
npm test)npm run typecheck)npm run lint)npm run pretty)docker-entrypoint.shno longer clobbers a pre-setOSC_ENVIRONMENTwhen deploying with a custom value🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com