refactor!: remove Python dependency via iRfcb 0.10.0 native MAT support - #39
Merged
Conversation
iRfcb 0.10.0 reads and writes MATLAB .mat files with a native R implementation, so ClassiPyR no longer needs Python/reticulate/scipy for any of its functionality. - Require iRfcb >= 0.10.0; drop reticulate from Imports - Deprecate init_python_env() (now a no-op) and run_app(venv_path=) - Remove Python startup initialization, the python_available flag, the "Python not available" warning banner, and the Python guards that blocked SQLite -> .mat and MATLAB ZIP exports - Drop the python_venv_path setting (stale keys in saved settings are ignored by the loader) - Remove Python bootstrap from testthat setup and all scipy skip guards, so MAT read/write tests now run everywhere - Remove Python/scipy setup steps from CI workflows - Update README, CONTRIBUTING and vignettes accordingly devtools::test(): 778 passing, 0 skipped devtools::check(): 0 errors, 0 warnings, 0 notes
…ecations Replace the ad-hoc .Deprecated()/warning() calls with the standard lifecycle pattern: - Add lifecycle to Imports and badge SVGs to man/figures/ - venv_path defaults to deprecated(); is_present() guards the deprecate_warn() call - Deprecation badges in the roxygen docs for both topics (per-block @md since the package does not use roxygen markdown globally) - Test asserts the lifecycle_warning_deprecated condition class devtools::check(): 0 errors, 0 warnings, 0 notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iRfcb 0.10.0 reads and writes MATLAB .mat files with a native R implementation, so ClassiPyR no longer needs Python/reticulate/scipy for any of its functionality.
devtools::test(): 778 passing, 0 skipped
devtools::check(): 0 errors, 0 warnings, 0 notes