Fix deposits rejected when account has negative balance#6515
Open
JRoy wants to merge 1 commit intoEssentialsX:2.xfrom
Open
Fix deposits rejected when account has negative balance#6515JRoy wants to merge 1 commit intoEssentialsX:2.xfrom
JRoy wants to merge 1 commit intoEssentialsX:2.xfrom
Conversation
Economy.add() delegated to setMoney() which checks minMoney and loan permission against the resulting balance. Both checks reject negative results even when the balance is improving from a deposit. Since deposits can only move the balance upward, route them directly to user.setMoney() bypassing the floor/loan checks. Withdrawals still go through setMoney() with full validation. Fixes EssentialsX#5606
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Economy.add() delegated to setMoney() which checks minMoney and loan
permission against the resulting balance. Both checks reject negative
results even when the balance is improving from a deposit. Since
deposits can only move the balance upward, route them directly to
user.setMoney() bypassing the floor/loan checks. Withdrawals still
go through setMoney() with full validation.
Fixes #5606