Particle effects Version 1 & 2#3520
Conversation
Both function independently of one another, so if a game was released using either version it should work flawlessly.
|
some stuff to consider /*
* This file is part of EasyRPG Player.
* ... (license header) ...
* Based on DynRPG Particle Effects V1 by Kazesui. (MIT license)
*/the generated code ignores the license code (my llm rigging of it had it removed to be economical, but it should be manually pasted) Other thing thing, does the v1 and v2 share or repeat code? |
|
Does this code address the non-working fast forward support? When pressing "F" to speedup the Player the particles (e.g. in Deep8) kept the same speed (or even worse: On 120 Hz displays the particles were twice as fast than the rest of the game). This was this "nobody understands the code Kazesui wrote" issue where I couldn't figure out how to split the Update and Draw logic. |
And added EasyRPG Distribution/GNU File info at top. Still trying to figure out Version 2 (I can get it to sync, but then we end up with a Vector Substack out of range error.)
|
As far as I know, the two versions are basically independent of one another, so probably keeping the code separate for now is probably the pragmatic way to go. I added the license info back and got V1 to sync with the acceleration (they were keeping the same speed and calling at the accelerated rate, which was creating a neat but undesirable effect. Basically moving the particles from "Draw" to "Update" - but it's causing a "Vector Substack Out of Range" overload on the V2 particle effects, so I'm going to have to play around with that one a bit more. |
Got it figured out - V2 particle animations now move at whatever speed the game is moving at, without overloading the vector.
|
Is the particles V2 based on my deep8 code from here? https://github.com/DeepIA8/easyrpg-player-deep8/blob/latest2/src/dynrpg_particle.cpp (Just asking as the simplest way to review it would me doing a diff so I know what I wrote myself) |
|
Originally it was but it's pretty much been completely re-written. Using a compare tool it appears 328 lines were taken out and 258 were added. So I would treat it as its own code. |
|
Could you link the kazesui dynrpg particle v1 source code? It looks like you "ported" it based on the dynrpg plugin but no idea where v1 can be found (I only have the V2 code) |
|
No idea how long this has been sitting in my RPG Maker folder, but here it is! |
|
I cannot see the plugins source code in this folder. That's a game with a DLL |
|
Sorry, wrong zip. Try this one. |
3 participants
Both function independently of one another, so if a game was released using either version it should work flawlessly.