Skip to content

Adding unit conversions for precipitation amount and surface snow amount - #3193

Open
lauracasp wants to merge 6 commits into
mainfrom
unit_conversion_precipitation
Open

Adding unit conversions for precipitation amount and surface snow amount#3193
lauracasp wants to merge 6 commits into
mainfrom
unit_conversion_precipitation

Conversation

@lauracasp

@lauracasp lauracasp commented Aug 10, 2026

Copy link
Copy Markdown

Description

Adding unit conversions for precipitation amount and surface snow amount implementing the equivalence of kg * m^-2 (amount per area) and mm (thickness of the amount).

The conversion is needed for the climatic impact-drivers recipe.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.49%. Comparing base (b22d2bd) to head (f0e2a1d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3193      +/-   ##
==========================================
- Coverage   96.50%   96.49%   -0.02%     
==========================================
  Files         280      280              
  Lines       16282    16282              
==========================================
- Hits        15713    15711       -2     
- Misses        569      571       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LisaBock
LisaBock requested a review from schlunma August 10, 2026 13:26

@schlunma schlunma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lauracasp, looks great! Could you please add two lines of documentation and a very simple test? You can basically Copy-paste the changes from #3182 and slightly adapt them. Thanks so much!

@LisaBock LisaBock self-assigned this Aug 10, 2026
@lauracasp

Copy link
Copy Markdown
Author

@schlunma thanks for the reference! Should all be done now.

@schlunma

Copy link
Copy Markdown
Contributor

Perfect! Please also mention it here, then this is good to go!

@schlunma schlunma added this to the v2.16.0 milestone Aug 11, 2026
@schlunma schlunma added the preprocessor Related to the preprocessor label Aug 11, 2026
@schlunma

Copy link
Copy Markdown
Contributor

One more thing I forgot: If you'd like, you can add yourself to the .zenodo.json and CITATION.cff files to get acknowledged as author 😊

@schlunma

Copy link
Copy Markdown
Contributor

Closing and re-opening to get CLAassistant to run

@schlunma schlunma closed this Aug 11, 2026
@schlunma schlunma reopened this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preprocessor Related to the preprocessor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants