Adding unit conversions for precipitation amount and surface snow amount - #3193
Adding unit conversions for precipitation amount and surface snow amount#3193lauracasp wants to merge 6 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3193 +/- ##
==========================================
- Coverage 96.50% 96.49% -0.02%
==========================================
Files 280 280
Lines 16282 16282
==========================================
- Hits 15713 15711 -2
- Misses 569 571 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
schlunma
left a comment
There was a problem hiding this comment.
Thanks @lauracasp, looks great! Could you please add two lines of documentation and a very simple test? You can basically Copy-paste the changes from #3182 and slightly adapt them. Thanks so much!
|
@schlunma thanks for the reference! Should all be done now. |
|
Perfect! Please also mention it here, then this is good to go! |
|
One more thing I forgot: If you'd like, you can add yourself to the .zenodo.json and CITATION.cff files to get acknowledged as author 😊 |
|
Closing and re-opening to get CLAassistant to run |
Description
Adding unit conversions for precipitation amount and surface snow amount implementing the equivalence of kg * m^-2 (amount per area) and mm (thickness of the amount).
The conversion is needed for the climatic impact-drivers recipe.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: