Skip to content

Result events#75

Open
rhysrevans3 wants to merge 15 commits into
ESGF:mainfrom
rhysrevans3:result_events
Open

Result events#75
rhysrevans3 wants to merge 15 commits into
ESGF:mainfrom
rhysrevans3:result_events

Conversation

@rhysrevans3

Copy link
Copy Markdown
Collaborator

General:

  • Have you followed the guidelines in our Contributing document?
  • Have all checks, quality assurance steps and tests passed?

Quality checks:

  • Have you updates the CHANGELOG.rst file?
  • Have you updated the version and author attributes (as appropriate) in the pyproject.toml file?

Community standards:

  • Have you followed Semantic Versioning?
  • Have you updated the docstrings and / or documentation files to reflect your change?

What is the purpose of this change?

The purpose of this change is to...

What does the change consist of?

This change consists of...

@sturoscy-personal sturoscy-personal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like it's changing too much. Will anything need updating at the transaction api level?

@rhysrevans3

Copy link
Copy Markdown
Collaborator Author

@sturoscy-personal no only changes will be in the consumer when posting results to the success/error topics.

@lukaszlacinski

Copy link
Copy Markdown

All event streams have six partitions. The event metadata should include both the partition number and the offset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants