Conversation
… chains to resolve issue #50
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Implements correct expression-tree emission for lambdas passed through IQueryable/Queryable chains by using Expression.Quote (instead of Expression.Convert) when converting a lambda to Expression<TDelegate>, addressing runtime failures described in issue #50.
Changes:
- Update the generator’s conversion emission to output
Expression.Quote(...)forExpression<TDelegate>conversion nodes. - Add generator- and runtime-level test coverage for an
[ExpressiveProperty]body containing anIQueryable<T>chain with lambda arguments. - Update verified generator output baselines to reflect
Quoteemission.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/ExpressiveSharp.Generator/Emitter/ExpressionTreeEmitter.cs |
Emits Expression.Quote for conversions targeting Expression<TDelegate> to fix IQueryable chain lambda handling. |
tests/ExpressiveSharp.IntegrationTests/Tests/SynthesizedExpressiveTests.cs |
Adds an integration test reproducing issue #50 behavior via ExpandExpressives() and query execution. |
tests/ExpressiveSharp.Generator.Tests/ExpressiveGenerator/ExpressivePropertyTests.cs |
Adds a generator test asserting Quote is emitted instead of Convert for lambda → Expression<TDelegate>. |
tests/ExpressiveSharp.Generator.Tests/ExpressiveGenerator/ExpressivePropertyTests.BodyUsingQueryableWhereOrderBy_EmitsValidExpressionTree.verified.txt |
Updates baseline to reflect Expression.Quote in generated output. |
tests/ExpressiveSharp.Generator.Tests/ExpressiveGenerator/ExpressivePropertyTests.BodyUsingQueryableLambdaChain_EmitsExpressionQuoteNotConvert.verified.txt |
Adds new verified baseline for the new generator test case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#50