Repository navigation
Conversation
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|
PR Description Check PassedAll required sections are filled in correctly. Details |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Second template for secuveri, a Swiss identity verification (KYC) service; the first,
secuveri.com/verify, was merged in #2760. Customers on our whitelabel plan can have their verification and dashboard emails sent from their own domain. secuveri registers the domain as an Amazon SES identity with Easy DKIM; this template adds the three DKIM CNAME records SES issues for it and a TXT record our backend checks to confirm the customer asked for it.hostRequired: false); ahostis used when the customer sends from a subdomain such asmail.example.com.%dkimSelector1%..%dkimSelector3%are the Easy DKIM tokens SES issues for the identity. Only the token part is variable: the host is fixed to%dkimSelectorN%._domainkeyand the target to%dkimSelectorN%.dkim.amazonses.com, so the template cannot point anywhere else.%token%is a per-domain ownership token (32 hex characters) generated by secuveri, prefixed assecuveri-verify=%token%on the fixed label_secuveri-sender.syncPubKeyDomain: secuveri.com, key at_dck1.secuveri.com, the same assecuveri.com/verify).Type of change
How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverAlso checked with
dc-template-linter(-merge-or-fail,-tolerate=warnand-logos): all exit 0.Checklist of common problems
syncPubKeyDomainis set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejectedwarnPhishingis not set alongsidesyncPubKeyDomain— the two must not appear togethersyncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flow"v=spf1 ...") — use theSPFMrecord type insteadtxtConflictMatchingModeis set on every TXT record that must be unique per label or content prefix (e.g. DMARC)@ TXT "%foo%") unless necessary — prefer@ TXT "service-foo=%foo%"; if bare, justify in the PR descriptionhostlabel — the non-variable parts are fixed to limit misuse (e.g.%dkimkey%._domainkey, not%dkimhost%); if bare, justify in the PR descriptionhostfield to create a subdomain — use thehostparameter ormultiInstanceinstead%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove without breaking the template (e.g. DMARC) — not applicable: all four records are required for sendingOnline Editor test results
Editor test link(s):
Test secuveri.com/sender example.com/@
Test secuveri.com/sender example.com/mail
Test values: three sample 32-character DKIM tokens and a sample ownership token on
example.com.