Repository navigation
Update xstate.io mail template to v2 (DMARC in its own group) - #3157
Open
agentfront-me wants to merge 1 commit into
Open
agentfront-me wants to merge 1 commit into
agentfront-me wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
PR Description Check PassedAll required sections are filled in correctly. Details |
Linter OK
|
| Level | Code | Note |
|---|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Version 2 of the xstate mail template (xstate.io/mail), already onboarded at Cloudflare.
mail(MX, SPFM, the three SES DKIM CNAMEs) anddmarc(the DMARC TXT). Weapply
dmarconly when the domain has no DMARC record yet. Cloudflare doesn't supporttxtConflictMatchingMode,so without groups an existing DMARC record would get a second one next to it, and receivers treat two as no
policy. Cloudflare honours
groupId.essentialremoved from the DMARC record: with the group the owner's existing record is kept anyway.go.xstate.comadded tosyncRedirectDomain: our app moved there, and it is where the flow now returns.Unchanged:
syncPubKeyDomainxstate.io, key_dck1, the variablesdkim1..dkim3(each only inside a fixedpattern: host
%dkimN%._domainkey, target%dkimN%.dkim.amazonses.com), and the logo.Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.
syncPubKeyDomainis set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejectedwarnPhishingis not set alongsidesyncPubKeyDomain— the two must not appear togethersyncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flow"v=spf1 ...") — use theSPFMrecord type insteadtxtConflictMatchingModeis set on every TXT record that must be unique per label or content prefix (e.g. DMARC)@ TXT "%foo%") unless necessary — prefer@ TXT "service-foo=%foo%"; if bare, justify in the PR descriptionhostlabel — the non-variable parts are fixed to limit misuse (e.g.%dkimkey%._domainkey, not%dkimhost%); if bare, justify in the PR descriptionhostfield to create a subdomain — use thehostparameter ormultiInstanceinstead%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove without breaking the template (e.g. DMARC): not set. DMARC is in its own group, which we leave out when the domain already has one, so the owner's record is never replaced; Cloudflare doesn't supportessential(linter DCTL5011).Online Editor test results
Editor test link(s):
example.com), groupsmailanddmarc: Test xstate.io/mail example.com/@example.com, hostmail), groupsmailanddmarc: Test xstate.io/mail example.com/mailmailonly (the domain already has DMARC; no_dmarcrecord is written): Test xstate.io/mail example.com/@, group mail only🤖 Generated with Claude Code