Repository navigation
Add signed Storeloom storefront templates for Cloudflare DNS - #3146
Open
martingtodorov wants to merge 2 commits into
Open
martingtodorov wants to merge 2 commits into
martingtodorov wants to merge 2 commits into
Conversation
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|
storeloom.com.storefront-subdomain.json
| Level | Code | Note |
|---|
PR Description Check PassedAll required sections are filled in correctly. Details |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds signed templates for Storeloom storefronts. The first connects the root domain and its www address. The second connects a selected subdomain. Each hostname gets its own routing target and ownership TXT record. Cloudflare flattens the root CNAME. The Cloudflare onboarding request will specify DNS-only records.
Type of change
How Has This Been Tested?
<providerId>.<serviceId>.json.dc-template-linter -merge-or-failand-cloudflare -tolerate warn -logos.Checklist of common problems
syncPubKeyDomainandsyncRedirectDomain.warnPhishingis omitted.storeloom-verify=prefix and prefix conflict matching. The templates contain no SPF or optional policy records.hostapply parameter. Variable CNAME targets stay undercustom.storeloom.com.Online Editor test results