RS-22478: Revert "fix stored XSS in metro HTML labels (#51)"#52
Merged
Conversation
JustinCCYap
changed the title
This reverts commit f95425c.
JustinCCYap
force-pushed
the
revert-RS-22478-metro-xss
branch
from
11e7539 to
584cd13
Compare
chschan
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts commit f95425c (#51).
This removes the DOMPurify sanitisation of
as_htmllabel content (and thedompurifydependency /sanitizeConfig.js), and reverts the version bump.Warning
The reverted commit was a stored XSS security fix (RS-22478). Merging this PR re-opens that vulnerability. Confirm this is intended before merging.
🤖 Generated with Claude Code