RS-22478: sanitize scatter labels and annotations with DOMPurify#92
Open
chschan wants to merge 1 commit into
Open
RS-22478: sanitize scatter labels and annotations with DOMPurify#92chschan wants to merge 1 commit into
chschan wants to merge 1 commit into
Conversation
Labels render as HTML so they can carry annotation markup (styled spans, HTML entities). Base labels are already _.escape'd; annotations are raw HTML. Sanitize the combined label HTML with DOMPurify in combineLabelsAndAnnotations, which keeps annotation formatting while stripping scripts and event handlers. This replaces the reverted .text() approach (#90/#91), which broke annotation rendering and showed escaped entities literally. Adds the dompurify dependency and rebuilds the inst/htmlwidgets bundle. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labels render as HTML so they can carry annotation markup (styled spans, HTML entities). .Sanitize the combined label HTML with DOMPurify in combineLabelsAndAnnotations, which keeps annotation formatting while stripping scripts and event handlers.
This replaces the reverted .text() approach (#90/#91), which broke annotation rendering and showed escaped entities literally. Adds the dompurify dependency and rebuilds the inst/htmlwidgets bundle.