Repository navigation
Redact password arguments from exception traces - #778
Merged
Merged
Conversation
stevebauman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LDAP passwords can appear in exception traces when authentication, password assignment, or a password change fails.
I've added
#[SensitiveParameter]to password arguments, including the newer OpenLDAP and Argon2 APIs. I've also covered authentication events and the model input methods that forward passwords, since annotating only the password mutator still leaves the value visible in earlier frames. Model attribute values and arrays are redacted in full.PHP 8.1 remains supported. Native parameter redaction takes effect on PHP 8.2 and newer.
Validated with the existing unit suite on PHP 8.4 and PHP 8.1, and Pint.
Closes #777.