Skip to content

[WPT check] Pin Taffy to row-flex fit-content fix (taffy#1298) - #1179

Open
nicoburns wants to merge 1 commit into
mainfrom
devin/1791721196-taffy-flex-fit-content
Open

nicoburns wants to merge 1 commit into
mainfrom
devin/1791721196-taffy-flex-fit-content

Conversation

@nicoburns

@nicoburns nicoburns commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Summary

Temporary pin PR, opened only to get CI WPT results (css-flexbox, css-grid) for DioxusLabs/taffy#1298. It is not meant to be merged.

Pins taffy to dc14152d (taffy#1298 head; based on 7d33901c, the rev Blitz main pins today). The only change is rev in Cargo.toml plus the matching Cargo.lock entry.

taffy#1298: an auto-width, single-line row flex container in definite available space is now sized as fit-content, min(max-content, max(min-content, available)), rather than as the sum of flex bases (fixes taffy#1296).

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/1ce9c912a46b4f9c9aaac5063c8561e4
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/1ce9c912a46b4f9c9aaac5063c8561e4?variant=devin-insiders
Requested by: @nicoburns

WPT results

Subtests: 11 newly passing, 0 newly failing (net +11).

Subtest changes by area (5 areas)
+ css                | +11 (+11 / -0) | 59.73% -> 59.73% (+0.01%) | 118515 -> 118526 / 198431
+   css-flexbox      | +10 (+10 / -0) | 86.19% -> 86.36% (+0.17%) |   5016 ->   5026 /   5820
+     intrinsic-size |  +6 ( +6 / -0) | 53.12% -> 62.50% (+9.38%) |     34 ->     40 /     64
+   css-sizing       |  +1 ( +1 / -0) | 61.72% -> 61.74% (+0.02%) |   4007 ->   4008 /   6492
+     aspect-ratio   |  +1 ( +1 / -0) | 63.20% -> 63.38% (+0.19%) |    340 ->    341 /    538
Full diff (8 changed tests)
+ FAIL => PASS    [6/6]  +1  css/css-flexbox/flex-minimum-size-001.html
+ FAIL => PASS  [18/18]  +2  css/css-flexbox/flex-one-sets-flex-basis-to-zero-px.html
+ FAIL => FAIL    [3/9]  +2  css/css-flexbox/intrinsic-size/row-005.html
+ FAIL => PASS    [1/1]  +1  css/css-flexbox/intrinsic-size/row-007.html
+ FAIL => FAIL   [2/11]  +2  css/css-flexbox/intrinsic-size/row-008.html
+ FAIL => FAIL    [5/6]  +1  css/css-flexbox/intrinsic-size/row-use-cases-001.html
+ FAIL => PASS    [1/1]  +1  css/css-flexbox/negative-margins-001.html
+ FAIL => PASS    [1/1]  +1  css/css-sizing/aspect-ratio/flex-aspect-ratio-055.html

Generated by the WPT workflow.

@staging-devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1791721196-taffy-flex-fit-content branch from 4449846 to 35c0ab7 Compare October 12, 2026 12:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant