Raptive custom min version - #93
Open
eyvazahmadzada wants to merge 3 commits into
Open
Conversation
10 tasks
DimaIntentIQ
reviewed
Sep 9, 2026
| @@ -1,98 +0,0 @@ | |||
| import { logError } from '../../src/utils.js'; | |||
Owner
There was a problem hiding this comment.
@eyvazahmadzada Why this was removed, don'y they use any kind of configuration based on browser? For examplebrowserBlackList
Collaborator
Author
There was a problem hiding this comment.
This is their configuration:
{
"partner": ...,
"timeoutInMillis": 500,
"partnerClientId": "...",
"partnerClientIdType": 3,
"manualWinReportEnabled": true,
"group": "A",
"ABTestingConfigurationSource": "group"
}
So, seems like nope
| * `window.intentIqAnalyticsAdapter_<partnerId>.reportExternalWin()`. | ||
| * Defaults to `false`. | ||
| */ | ||
| manualWinReportEnabled?: boolean; |
Owner
There was a problem hiding this comment.
As I remember when they used Analytical adapter, they used manual reporting, pls ask Shahar about it
Collaborator
Author
There was a problem hiding this comment.
They do set manualWinReportEnabled, but it won't break anything because we will simply not use it (it's always true)
| /** | ||
| * Geo-region routing hint for the reporting server. | ||
| */ | ||
| region?: string; |
Owner
There was a problem hiding this comment.
Also I think they could be active in Europe as well, again pls clarify it with Shahar
| * 3 = adUnitCode only | ||
| * 4 = placementId only | ||
| */ | ||
| adUnitConfig?: 1 | 2 | 3 | 4; |
| /** | ||
| * Publisher domain name appended to report URLs. | ||
| */ | ||
| domainName?: string; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information