telemetry: a runner without sudo is not a failed run

[grahamc]

store_identity writes a convenience file for the programs the Action runs. A runner with no usable sudo cannot write it and gets on fine without it, but the span reported an error, which is the same mistake the determinate-nixd socket was.

The outcome is now detsys.identity.stored, with the reason in detsys.identity.store_error. Both flavours are covered: sudo missing, and sudo present but refusing.

Description

Checklist

• Tested changes against a test repository
• Added or updated relevant documentation (leave unchecked if not applicable)
• (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

Summary by CodeRabbit

• Bug Fixes
  • Improved resilience during identity data storage. Storage errors are now recorded for diagnostics without interrupting the rest of the operation.
  • Added clearer telemetry for successful and unsuccessful identity persistence attempts.

[netlify]

✅ Deploy Preview for detsys-ts-docs ready!

Name	Link
🔨 Latest commit	ea49972
🔍 Latest deploy log	https://app.netlify.com/projects/detsys-ts-docs/deploys/6aa1955dce70510008bd46e9
😎 Deploy Preview	https://deploy-preview-233--detsys-ts-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: a4a87ce3-99a1-42ef-9439-6d23a2334053

📥 Commits

Reviewing files that changed from the base of the PR and between 52464f1 and ea49972.

📒 Files selected for processing (1)

• src/index.ts

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

---

📝 Walkthrough

Walkthrough

Identity persistence now runs failure handling inside the store_identity span. The code records storage success or serialized errors and continues execution when writing the identity file fails.

Changes

Identity storage telemetry

Layer / File(s)	Summary
Record identity storage outcomes src/index.ts	The code adds telemetry attribute constants and records identity storage success or serialized errors. Write failures no longer mark the span as failed or interrupt execution.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ea499

Identity-file write failures now remain non-fatal and are recorded as telemetry attributes, preserving Action execution when sudo is unavailable or refuses the write. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main telemetry change: a runner that cannot use sudo is not reported as a failed run.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch otel-identity-store-not-an-error

---

_{Comment @coderabbitai help to get the list of available commands.}